Skip to content

feat: decouple app lifecycle actions; add indexes to improve CI query… - #7019

Merged
Shivam-nagar23 merged 2 commits into
mainfrom
feat/dev-admin-app-lifecycle
Sep 7, 2026
Merged

Shivam-nagar23 merged 2 commits into
mainfrom
feat/dev-admin-app-lifecycle

Conversation

@Shivam-nagar23

@Shivam-nagar23 Shivam-nagar23 commented Sep 2, 2026 •

Copy link
Copy Markdown
Member

… performance

  • Introduce createApp/deleteApp actions to segregate application lifecycle control from pipeline/workflow/config operations.
  • Update RBAC enforcement to reflect the new createApp/deleteApp actions for better granularity.
  • Add idx_ci_artifact, idx_ci_workflow, and other indexes to improve CI query execution and resolve PG_READ_TIMEOUT issues.
  • Introduce GIN index for git_triggers to optimize material/commit lookup in validateBuildSequence.

Description

Fixes https://github.com/devtron-labs/sprint-tasks/issues/2955

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?


Summary by Bito

  • Decoupled application lifecycle management (create/delete) from general pipeline/workflow operations by introducing new Casbin actions: ActionCreateApp and ActionDeleteApp.
  • Updated CoreAppRestHandler and PipelineConfigRestHandler to enforce these new actions for application creation and deletion.
  • Added logic to distinguish between Job and Application types during RBAC enforcement to ensure granular control.
  • Removed redundant RBAC enforcement in ApiTokenRestHandler.

… performance

- Introduce `createApp`/`deleteApp` actions to segregate application lifecycle control from pipeline/workflow/config operations.
- Update RBAC enforcement to reflect the new `createApp`/`deleteApp` actions for better granularity.
- Add `idx_ci_artifact`, `idx_ci_workflow`, and other indexes to improve CI query execution and resolve PG_READ_TIMEOUT issues.
- Introduce GIN index for `git_triggers` to optimize material/commit lookup in `validateBuildSequence`.
@github-actions

github-actions Bot commented Sep 2, 2026

Copy link
Copy Markdown

Some linked issues are invalid. Please update the issue links:\nIssue # in is not found or invalid (HTTP }404).\n

@github-actions

github-actions Bot commented Sep 2, 2026

Copy link
Copy Markdown

Some linked issues are invalid. Please update the issue links:\nIssue # in is not found or invalid (HTTP }404).\n

1 similar comment
@github-actions

github-actions Bot commented Sep 2, 2026

Copy link
Copy Markdown

Some linked issues are invalid. Please update the issue links:\nIssue # in is not found or invalid (HTTP }404).\n

@Shivam-nagar23
Shivam-nagar23 merged commit 418ccc7 into main Sep 7, 2026
9 of 10 checks passed
@Shivam-nagar23
Shivam-nagar23 deleted the feat/dev-admin-app-lifecycle branch September 7, 2026 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants