Repository navigation
Conversation
vjymisal0
requested review from
prakarsh-dt and
vivek-devtron
as code owners
September 7, 2026 12:20
|
Bito Review Skipped - Source Branch Not Found |
…batch query helpers Clean up redundant if-else branches in AppStoreApplicationVersionRepository and UserAuthRepository, add batch repository helpers, and add unit test coverage.
vjymisal0
force-pushed
the
fix/redundant-query-branches-and-auth-lookups
branch
from
September 21, 2026 06:34
0076c51 to
261b8cd
Compare
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR title
fix(auth,appstore): eliminate identical conditional branches and add batch query helpers
What changed
if-then-elseifbranches inFindAllWithFilterwhere each branch executed the exact same query invocation (Fixes All branches ofif-then-elseifconstruction are identical #6030).else ifbranch inGetRoleForOtherEntity(Fixes Both branches ofif-then-elseare identical #6031).FindAppStoresByChartRepoIdsbatch query helper with empty slice short-circuiting.GetRoleGroupsByIdsbatch helper for bulk lookup operations.pkg/appStore/discover/repository/AppStoreApplicationVersionRepository_test.gopkg/auth/user/repository/UserAuthRepository_test.goWhy
Validation
go test.Closes #6030
Closes #6031