Repository navigation
Conversation
BuildK8sObjectListTableData in common-lib lower-cases the Table column names when it builds the row maps (keys become "sync status" / "health status"), but getApplicationListDtos looked the values up with the printer-column constants "Sync Status" / "Health Status". The lookup never matched, so the ArgoCD Apps list rendered "-" for every external Argo application even though the Kubernetes Table API returned Synced/Healthy. Lower-case the lookup keys to match what the row builder produces. Signed-off-by: kacpernajda <kacper.najda2001@gmail.com>
|
Bito Review Skipped - Source Branch Not Found |
|
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing. Review the Copilot code review billing settings.
|
Description
Fixes #7030
On the ArgoCD Apps tab every external Argo CD application shows
-as its status, andGET /orchestrator/argo-applicationreturns emptyappStatus/syncStatus, although theApplicationobjects areSynced/Healthy.BuildK8sObjectListTableData(common-libutils/k8s/K8sUtil.go) lower-cases the Table column names when it builds the row maps, so the row keys aresync status/health status.getApplicationListDtoslooked the values up with the printer-column constants"Sync Status"/"Health Status", which never match.This PR lower-cases the lookup keys (derived from the same constants, so the two places cannot drift apart again) and adds a comment explaining why.
How was this verified
POST /orchestrator/k8s/resource/listforargoproj.io/v1alpha1 Applicationon a running Devtron (1188d0b9) returnsheaders: ["name", "namespace", "sync status", "health status"]withSynced/Healthyin the rows, while the list endpoint returned empty strings.pkg/argoApplication/ArgoApplicationService.go), so nothing else changes behaviour.Checklist