Skip to content

misc: Conditions saved with the plugin definition (plugin_step_condition) a… - #7035

Merged
prakash100198 merged 2 commits into
mainfrom
support-trigger-conditions-pipeline-level-oss
Sep 15, 2026
Merged

prakash100198 merged 2 commits into
mainfrom
support-trigger-conditions-pipeline-level-oss

Conversation

@prakash100198

@prakash100198 prakash100198 commented Sep 14, 2026 •

Copy link
Copy Markdown
Contributor

…re intentionally not sent for the plugin's internal steps.

Description

Fixes https://github.com/devtron-labs/sprint-tasks/issues/2957

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?


Summary by Bito

  • Refactored PipelineStageService to stop sending plugin-level conditions (plugin_step_condition) in workflow requests, as these are intended only as default values.
  • Renamed BuildPluginVariableAndConditionDataForWfRequest to BuildPluginVariableDataForWfRequest, removing the condition-processing logic.
  • Added new regression tests in PipelineStagePipelineConditions_test.go and PipelineStagePluginConditions_test.go to ensure correct condition handling for pipeline-level steps.

…re intentionally not sent for the plugin's internal steps.
@github-actions

Copy link
Copy Markdown

Some linked issues are invalid. Please update the issue links:\nIssue # in is not found or invalid (HTTP }404).\n

@github-actions

Copy link
Copy Markdown

Some linked issues are invalid. Please update the issue links:\nIssue # in is not found or invalid (HTTP }404).\n

@github-actions

Copy link
Copy Markdown

Some linked issues are invalid. Please update the issue links:\nIssue # in is not found or invalid (HTTP }404).\n

@sonarqubecloud

Copy link
Copy Markdown

@prakash100198 prakash100198 changed the title fix: Conditions saved with the plugin definition (plugin_step_condition) a… misc: Conditions saved with the plugin definition (plugin_step_condition) a… Sep 15, 2026
@prakash100198
prakash100198 merged commit 72dcd49 into main Sep 15, 2026
11 of 12 checks passed
@prakash100198
prakash100198 deleted the support-trigger-conditions-pipeline-level-oss branch September 15, 2026 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants