Repository navigation
feat: migrate foreground delete on cd pipeline delete from ent to oss - #7037
Merged
Merged
Conversation
Cherry-picked from devtron-enterprise #3373. * add FOREGROUND_DELETE_CD_PIPELINE env config * add nullable foregroundDelete query param + resolution against env default * skip deployed resource deletion (helm/argocd/flux) on foreground CD pipeline delete * honor foregroundDelete in async CD pipeline delete event * validate conflicting force/cascade/foregroundDelete options in PatchCdPipeline * expose foregroundDeleteCdPipeline in GET /environment-variables
* renumber variable_entity_mapping_index 36504600 -> 36704600 (36504600 was duplicated with add_ci_workflow_active_status_index) * add empty placeholder 36604600_approval_declined_notification (enterprise-only feature)
SATYAsasini
requested review from
prakarsh-dt and
vivek-devtron
as code owners
September 15, 2026 09:39
|
Bito Automatic Review Skipped - Branch Excluded |
|
Some linked issues are invalid. Please update the issue links:\nIssue # in is not found or invalid (HTTP }404).\n |
|
SATYAsasini
changed the title
|
Some linked issues are invalid. Please update the issue links:\nIssue # in is not found or invalid (HTTP }404).\n |
github-actions
Bot
added
PR:Ready-to-Review
and removed
PR:Issue-verification-failed
labels
Ash-exp
approved these changes
Sep 15, 2026
vivek-devtron
approved these changes
Sep 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes https://github.com/devtron-labs/sprint-tasks/issues/2961
Checklist:
Does this PR introduce a user-facing change?