Skip to content

bug: docker build arg fix - #7057

Merged
prakash100198 merged 1 commit into
mainfrom
fix/override-build-args-2983
Oct 14, 2026
Merged

prakash100198 merged 1 commit into
mainfrom
fix/override-build-args-2983

Conversation

@prakash100198

@prakash100198 prakash100198 commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

Description

Fixes https://github.com/devtron-labs/sprint-tasks/issues/2983

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?


Summary by Bito

  • Added a method `ClearDockerBuildArgs` to `CiBuildConfigBean` to explicitly remove Docker build arguments from CI pipeline overrides.
  • Updated `CiTemplateReadService` to invoke `ClearDockerBuildArgs` when extracting build configuration, preventing stale build arguments from being served or used in builds.
  • Added comprehensive unit tests for `CiBuildConfigBean` and `CiTemplateReadService` to verify the clearing logic and ensure no other build configuration fields are affected.

@sonarqubecloud

Copy link
Copy Markdown

@prakash100198
prakash100198 merged commit 54a19b4 into main Oct 14, 2026
14 checks passed
@prakash100198
prakash100198 deleted the fix/override-build-args-2983 branch October 14, 2026 12:58
@prakash100198 prakash100198 changed the title misc: docker build arg fix bug: docker build arg fix Oct 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants