[claude]

Requested by Shivam Nagar · Slack thread

Description

Fixes #7066

Before: a filter-based bulk delete (e.g. {"listingRequest":{"searchKey":"abc"}} with no explicit ids) resolved only the first page of 20 matching users and silently left the rest in place.

After: a filter-based bulk delete resolves every matching user, as the listing filter implies.

How: getUserIdsHonoringFilters (pkg/auth/user/UserService.go) applies the listing normalization, which defaults Size to bean.DefaultSize (20); GetQueryForUserListingWithFilters then appends limit ? offset ? unless ShowAll is set. The fix sets request.ShowAll = true after the normalization calls and before the query is built, with an explanatory comment. The same fix landed in devtron-enterprise via devtron-labs/devtron-enterprise#3407. GetAllWithFilters, the query builder and the explicit-ids delete path are unchanged.

How Has This Been Tested?

Extended pkg/auth/user/UserService_bulkdelete_filter_test.go:

• TestGetUserIdsHonoringFilters_DoesNotPaginate (new): 25 matching users (more than the default page size of 20) all get resolved, ShowAll is forced true, and the query has no limit ? offset ? and no bound page size. It also builds the pre-fix query (same input, no ShowAll) and asserts it is paginated with the default page size, so the test fails if the fix is reverted.
• TestGetUserIdsHonoringFilters_MatchesListingQuery (updated): the listing path paginates by default while the delete path intentionally does not, so the expected listing query is now built with ShowAll = true.
• TestGetUserIdsHonoringFilters_RejectsUnscopedFilter: unchanged.

go build ./pkg/auth/user/... succeeds. go test ./pkg/auth/user/ -run TestGetUserIdsHonoringFilters -v -vet=off passes all three tests, and temporarily removing the ShowAll = true line makes the new and updated tests fail. As with #7021, pkg/auth/user/UserService_test.go and UserFlows_test.go already fail to compile on main (stale NewUserCommonServiceImpl signature etc.), so I temporarily moved them aside to run the tests; they are restored and not part of this change. gofmt -l is clean.

Checklist:

• The title of the PR states what changed and the related issues number (used for the release note).
• Does this PR requires documentation updates?
• I've updated documentation as required by this PR.
• I have performed a self-review of my own code.
• I have commented my code, particularly in hard-to-understand areas.
• I have tested it for all user roles.
• I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?

Fixed a bug where a filter-based bulk user delete only deleted the first 20 matching users and silently left the rest. It now applies to every user matching the filter.

---

Generated by Claude Code

[bito-code-review]

Bito Automatic Review Skipped - Draft PR

Bito didn't auto-review because this pull request is in draft status.
No action is needed if you didn't intend for the agent to review it. Otherwise, to manually trigger a review, type /review in a comment and save.
You can change draft PR review settings here, or contact your Bito workspace admin at shivam@devtron.ai.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud