Repository navigation
fix: restore the share image on the DSOC pages - #97
Merged
Merged
Conversation
Setting only the address in openGraph replaced the whole object, so /dsoc/projects lost its og:image in the previous change. Both DSOC layouts now use the shared helper, which fills the address, title, description and image together.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The crawl after #96 showed
/dsoc/projectswithout anog:image. In #96 I gave the DSOC layouts anopenGraphobject holding only the address, and Next replaces the parent's object instead of merging it, so the image was dropped.What changes
Both DSOC layouts use
withSocial, the helper every other page uses, which sets the address, title, description and image together.Checked
Type check passes. The live crawl will be rerun after deploy.