Skip to content

add serialization format configuration #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lalaguozhe wants to merge 2 commits into
base: cosmos-hive-0.11.0
Choose a base branch
from
Open

add serialization format configuration #52

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
879db77
add serialization format configuration
lalaguozhe Sep 3, 2014
eba77c4
print column header field delimiter according to serialization format
lalaguozhe Sep 4, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -333,9 +333,14 @@ private void printHeader(Driver qp, PrintStream out) {
&& fieldSchemas != null) {
// Print the column names
boolean first_col = true;
String serializationFormat = HiveConf.getVar(conf, HiveConf.ConfVars.HIVE_LISTSINK_SERIALIZATION_FORMAT);
for (FieldSchema fs : fieldSchemas) {
if (!first_col) {
out.print('\t');
if (!StringUtils.isEmpty(serializationFormat)) {
out.print((char)Integer.parseInt(serializationFormat));
} else {
out.print('\t');
}
}
out.print(fs.getName());
first_col = false;
Expand Down
2 changes: 2 additions & 0 deletions common/src/java/org/apache/hadoop/hive/conf/HiveConf.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -767,6 +767,8 @@ public static enum ConfVars {
HIVESERVER_KERBEROS_KEYTAB_FILE("hive.hiveserver.kerberos.keytab.file", ""),
HIVESERVER_KERBEROS_PRINCIPAL("hive.hiveserver.kerberos.principal", ""),
HIVESERVER_USE_THRIFT_SASL("hive.hiveserver.sasl.enabled", false),

HIVE_LISTSINK_SERIALIZATION_FORMAT("hive.listsink.serialization.format", ""),
;

public final String varname;
Expand Down
8 changes: 7 additions & 1 deletion ql/src/java/org/apache/hadoop/hive/ql/exec/ListSinkOperator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
import java.util.ArrayList;
import java.util.Properties;

import org.apache.commons.lang.StringUtils;
import org.apache.hadoop.conf.Configuration;
import org.apache.hadoop.hive.common.JavaUtils;
import org.apache.hadoop.hive.conf.HiveConf;
Expand Down Expand Up @@ -65,7 +66,12 @@ private SerDe initializeSerde(Configuration conf) throws Exception {

// this is the default serialization format
if (serde instanceof DelimitedJSONSerDe) {
serdeProp.put(serdeConstants.SERIALIZATION_FORMAT, "" + Utilities.tabCode);
String serializationFormat = getConfiguration().get(HiveConf.ConfVars.HIVE_LISTSINK_SERIALIZATION_FORMAT.varname);
if (!StringUtils.isEmpty(serializationFormat)) {
serdeProp.put(serdeConstants.SERIALIZATION_FORMAT, "" + Integer.parseInt(serializationFormat));
} else {
serdeProp.put(serdeConstants.SERIALIZATION_FORMAT, "" + Utilities.tabCode);
}
serdeProp.put(serdeConstants.SERIALIZATION_NULL_FORMAT, getConf().getSerializationNullFormat());
}
serde.initialize(conf, serdeProp);
Expand Down