perf(electron): optionally unload renderer on close (4/8) - #10328
Merged
diegosouzapw merged 4 commits intoAug 20, 2026
Merged
Conversation
37 tasks
backryun
force-pushed
the
perf/electron-unload-on-close
branch
4 times, most recently
from
August 14, 2026 15:55
be7eae4 to
e161c60
Compare
backryun
force-pushed
the
perf/electron-unload-on-close
branch
6 times, most recently
from
August 15, 2026 01:52
489e260 to
811244f
Compare
backryun
force-pushed
the
perf/electron-unload-on-close
branch
9 times, most recently
from
August 16, 2026 09:34
c133dc4 to
3d7ee3e
Compare
Owner
|
IN-FLIGHT — deferido. O head desta PR está no checkout principal concorrente (perf/electron-unload-on-close). Não faço merge, rebase, push nem alteração nesse checkout. |
backryun
force-pushed
the
perf/electron-unload-on-close
branch
3 times, most recently
from
August 17, 2026 17:42
3e2db74 to
280a4bc
Compare
backryun
force-pushed
the
perf/electron-unload-on-close
branch
from
August 18, 2026 04:54
280a4bc to
6c19702
Compare
backryun
force-pushed
the
perf/electron-unload-on-close
branch
10 times, most recently
from
August 20, 2026 13:23
607467c to
47f17a1
Compare
backryun
force-pushed
the
perf/electron-unload-on-close
branch
from
August 20, 2026 13:39
47f17a1 to
2dd0e4e
Compare
Merged — locally validated (123/123 focused chatgpt-web tests, typecheck:core clean, file-size/changelog gates green). Thanks!
…w/OmniRoute into HEAD # Conflicts: # electron/main.js
diegosouzapw
merged commit Aug 20, 2026
8122f6b
into
diegosouzapw:release/v3.8.50
2 of 5 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
keep-loadedas the default, preserving the existing fast-reopen behaviorCloses the Stage 4 implementation slice tracked by #10321.
Measured behavior
Measured on macOS arm64 with an isolated Electron profile and a lightweight remote dashboard fixture:
/dashboard/settings?stage4=1stage4_session=preservedThese numbers isolate shell/renderer overhead with a lightweight page; production dashboard totals will vary. The active app has no custom deep-link protocol (
omniroute://was previously removed because no handler existed), so there is no deep-link state to restore. External-link handling is unchanged. Auto-update listeners remain in the main process and renderer notifications safely no-op while the window is absent.Validation
node --import tsx/esm --test tests/unit/electron*.test.ts tests/unit/build/electron-release-latest-yml.repro.test.ts— 134 passednpm run test:vitest— 357 passednpm run check:file-size— passednode --check electron/main.js electron/lib/remoteServerPreferences.js electron/lib/windowClosePolicy.js— passedFull-repository
npm run lintremains blocked by pre-existing errors in@omniroute/opencode-plugin/src/index.tsandtests/unit/cli-env-inline-comment-10100.test.ts; neither file is changed here.