Skip to content

fix(quality): drain v3.8.50 base-reds — doc counts + orphan uncloseai test - #11160

Merged
diegosouzapw merged 1 commit into
diegosouzapw:release/v3.8.50from
yourspraveen:fix/release-v3.8.50-basereds-docs-counts-orphan
Aug 22, 2026
Merged

fix(quality): drain v3.8.50 base-reds — doc counts + orphan uncloseai test#11160
diegosouzapw merged 1 commit into
diegosouzapw:release/v3.8.50from
yourspraveen:fix/release-v3.8.50-basereds-docs-counts-orphan

Conversation

@yourspraveen

Copy link
Copy Markdown
Contributor

Drains two HARD failures that have been red on release/v3.8.50 for every PR targeting it. Reported on #9985; neither belongs to the PRs that tripped over them.

1. check:docs-counts — job Docs Gates (fast-path)

Three counts drifted when code landed without the matching doc update:

Claim Docs said Code has Origin
DB migrations 157 159 84c9dfdd2 (#11103) → 161_config_audit_log.sql; aa1287368 (#11118/#11123) → 162_remove_hackclub_provider.sql
free-forever providers 57 56 aa1287368 (#11118/#11123) — Hack Club AI removed
free-tier provider pools 41 40 same

The migration count lives in README.md, AGENTS.md and llm.txt, and llm.txt is mirrored into 42 locales under docs/i18n/<locale>/llm.txt. check:docs-sync requires the mirrors to match the root, so all 45 files move together — that is why the diff is wide but shallow (one number per file). The free-forever and pool counts are hand-maintained numbers baked into README.md and two SVGs (promise-pillars, free-tier-budget), including their alt/desc text, so those were updated in place.

2. check:test-discovery — job Fast Quality Gates

✗ [órfão NOVO] tests/unit/providers/uncloseai-noauth.test.ts — nenhum runner coleta este arquivo (ele NUNCA roda).

tests/unit/providers/uncloseai-noauth.test.ts was the only file under tests/unit/providers/, and providers is absent from the collected-directory list in test:unit / test:unit:ci:shard:

tests/unit/{api,auth,authz,build,cli,cli-helper,combo,compression,correctness,cors,db,db-adapters,
docs,gamification,guardrails,lib,mcp,memory,runtime,security,settings,shared,services,ui,usage}

So it has never executed since landing in d61eec63b (#8864/#11064). The gate failure is the smaller problem — the real cost is that the UncloseAI no-auth regression it guards has been unprotected this whole time.

Moved to tests/unit/providers-uncloseai-noauth.test.ts, matching the existing root-level convention (providers-page-utils, providers-validate-route, providers-route-managed-catalog, …). It imports only through the @/ alias, so directory depth is irrelevant, and it passes now that it actually runs. Widening the runner glob instead was the alternative, but that changes shard composition for a directory holding one file.

Verification

Gate Before After
check:docs-counts 3 STRICT drifts exit 0
check:docs-all fail exit 0
check:docs-sync (42 locale mirrors) pass pass
check:test-discovery 1 orphan exit 0
check:mutation-test-coverage pass pass (no drift; test still listed)
tests/unit/providers-uncloseai-noauth.test.ts never ran 1 pass

No production code changes — docs counts plus one test-file move.

yourspraveen pushed a commit to yourspraveen/OmniRoute that referenced this pull request Aug 22, 2026
@diegosouzapw
diegosouzapw force-pushed the fix/release-v3.8.50-basereds-docs-counts-orphan branch from 07a3811 to 1cc37f9 Compare August 22, 2026 23:41
@diegosouzapw
diegosouzapw merged commit ce66d31 into diegosouzapw:release/v3.8.50 Aug 22, 2026
2 of 5 checks passed
diegosouzapw pushed a commit that referenced this pull request Aug 23, 2026
…0964)

Merged after conflict triage: the six base-red repair files (vi.json, opencode.ts JSDoc, context-manager test, the three webhook dispatcher tests, the uncloseai orphan-test rename) were already drained on the tip by today's #11130/#11157/#11160/#11113 — those hunks resolved to the tip shape. What lands is the production-fix set: GLM transport-aware Anthropic headers, Claude Code-compatible model-listing rejection, combo live-test single-probe, zero-cost Auto-Combo interval normalization, recovery-clearing union handling, LLMLingua real-path compare, macOS netstat PID discovery, AI Horde R2 strict public-host validation. Sweep of every touched test file: 243/243 green; typecheck + file-size clean. (guide-settings-route's 4 reds reproduce on the pure tip — pre-existing drift from #11079, not from here.) Thank you @backryun!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants