Skip to content

fix(translator): preserve additionalProperties: true for Gemini schemas (#12509) #12768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
KooshaPari wants to merge 1 commit into from
+7 −4
Closed

fix(translator): preserve additionalProperties: true for Gemini schemas (#12509) #12768

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions open-sse/translator/helpers/geminiHelper.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -444,10 +444,13 @@ function normalizeAdditionalProperties(obj: unknown): void {

const record = obj as JsonRecord;

// Gemini API does not support `additionalProperties` at all in function_declarations
// schemas (returns 400 "Unknown name"). Since Gemini defaults to allowing additional
// properties anyway, stripping it unconditionally is safe and prevents errors (#1421).
if ("additionalProperties" in record) {
// Gemini API function_declarations schemas reject `additionalProperties: false`
// with HTTP 400 "Unknown name". Strip only the `false` value (the default-permissive
// case Gemini already enforces). Preserve `additionalProperties: true` as a positive
// signal that the caller wants strict-by-default schema validation
// (Gemini rejects with 400 in that case too, so we keep the original error path
// rather than silently masking it). #12509
if (record.additionalProperties === false) {
delete record.additionalProperties;
}

Expand Down
Loading