Skip to content

fix(i18n): quote <name> placeholder in OMNIROUTE_AUTO_SYNC_CLAUDE_PROFILES description (#12505) - #12769

Merged
diegosouzapw merged 1 commit into
diegosouzapw:release/v3.8.51from
KooshaPari:pr/12505-icu-name-escape
Sep 5, 2026
Merged

fix(i18n): quote <name> placeholder in OMNIROUTE_AUTO_SYNC_CLAUDE_PROFILES description (#12505)#12769
diegosouzapw merged 1 commit into
diegosouzapw:release/v3.8.51from
KooshaPari:pr/12505-icu-name-escape

Conversation

@KooshaPari

Copy link
Copy Markdown
Contributor

Summary

Fixes #12505

ICU MessageFormat parses literal <name> as the start of a plural/select placeholder in several locales (ar, ja, ko, zh, vi, ru). Since the rest of the sentence has no valid expression for the slot, the parser errors silently and the entire description renders as the English fallback.

Apostrophe-escaping <name> tells ICU the angle-brackets are a literal string, not a placeholder. Now all 43 locale catalogs render the description correctly.

Diff

-    "When enabled, OmniRoute auto-creates a named profile (<name>) in
+    "When enabled, OmniRoute auto-creates a named profile ('<name>') in
     ~/.claude.json..."

Single-character-class fix, no schema/dependency/permission impact.

Fixes #12505

Copilot AI lite review requested due to automatic review settings September 5, 2026 04:32

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

…FILES description (diegosouzapw#12505)

ICU MessageFormat parses literal '<name>' as the start of a
plural/select placeholder in several locales (ar, ja, ko, zh, vi, ru).
Since the rest of the sentence has no valid expression for the slot,
the parser errors silently and the entire description renders as the
English fallback.

Apostrophe-escaping '<name>' tells ICU the angle-brackets are a
literal string, not a placeholder. Now all 43 locale catalogs render
the description correctly.

Single-character-class fix.

Fixes diegosouzapw#12505

(cherry picked from commit 1cd86f4)
@diegosouzapw
diegosouzapw force-pushed the pr/12505-icu-name-escape branch from 1cd86f4 to d07863e Compare September 5, 2026 05:32
@diegosouzapw
diegosouzapw changed the base branch from main to release/v3.8.51 September 5, 2026 05:32
@diegosouzapw
diegosouzapw merged commit 366099a into diegosouzapw:release/v3.8.51 Sep 5, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix: escape raw <name> tag in OMNIROUTE_AUTO_SYNC_CLAUDE_PROFILES description across 43 locales

3 participants