fix(glm): drop extra 16th arg to SSE transform helper - #12770
Open
HouMinXi wants to merge 1 commit into
Open
Conversation
createSSETransformStreamWithLogger takes 15 parameters. The 65536 positional was a TS2554 and never reached TransformStream. Last arg is suppressThinkClose. Signed-off-by: Minxi Hou <houminxi@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
translateSseResponseinopen-sse/executors/glm.tspassed a 16th positional (65536) tocreateSSETransformStreamWithLogger. That helper has 15 parameters (open-sse/utils/stream.ts:2998-3013); last isrequestToolIdentityMap. tsc reports TS2554. The number never reachedTransformStream. The old comment about a 64KB buffer was wrong.This is the same one-line drop that landed inside #12711. Isolated here so pin / combo-split / moonshot do not have to carry
glm.ts.Fix
Drop
undefined, undefined, 65536. Last argument stayssuppressThinkClose. Comment now matches the helper.Tests
tests/unit/glm-sse-transform-arity.test.ts— source guard: helper has nohighWaterMarkslot; GLM call site has no65536and ends onsuppressThinkClose.tests/unit/glm-think-close-marker-leak.test.tsstill green (3/3).65536back → arity test red. Restore → 2/2 green.KeyHealth/translateJsonResponseunused on tip are not in this diff.Not in this PR
reset-aware-model-family.mdmissing-(🔴 Release branch not green: release/v3.8.51 #12732)cli-tunnelskill dry-run generateContributor only — not merging.