refactor(simba): deduplicate schema in four metadata models (#218)

Phase 3 simba-model-layer-refactor: chuẩn hóa 4 Model chỉ extend SModel generated.

- SysDictionaryInfo, SysReportInfo, SysReportDrillDownInfo, SiDmCt: bỏ khai báo lại ///////.
- SysReportInfo (menuid, ma_mau), SysReportDrillDownInfo (menuid, ma_mau, press_key_name), SiDmCt (ma_cty, ma_ct): dùng HasSimbaCompositeKey.
- Behavior giữ nguyên: primaryKeyFields, carryFields, scopeCodeName, scopeMenuId, scopeVoucher, headerFieldsForInventory, detailFieldsForInventory.
- Sai lệch casts cũ đã loại: SysReportInfo (bang_chu/bang_chu0/hasNT theo docs là NVARCHAR), SiDmCt (VoucherGetWhenOpenForm không có trong docs, DB thật integer).
- CI 14/14 pass, lint 4/4, caller laravel-catalog chỉ dùng query/attribute — không phá API.

Author: caothu159

src/Models/SiDmCt.php

@@ -8,102 +8,52 @@
  * @author     Tran Ngoc Duc <ductn@diepxuan.com>
  * @author     Tran Ngoc Duc <caothu91@gmail.com>
  *
- * @lastupdate 2026-06-05 20:58:00
+ * @lastupdate 2026-06-21
  */
 
 namespace Diepxuan\Simba\Models;
 
-use Diepxuan\Simba\SModel\SModel;
+use Diepxuan\Simba\Models\Concerns\HasSimbaCompositeKey;
+use Diepxuan\Simba\SModel\SiDmCtModel as SModel;
 
 /**
  * Model SiDmCt - Khai báo màn hình nhập chứng từ.
  *
  * Source: simba-docs/tables/SiDmCt.md.
+ *
+ * Schema nằm trọn ở `SiDmCtModel`. Model này chỉ giữ behavior Simba-level
+ * và `HasSimbaCompositeKey` để thao tác theo composite primary key
+ * (ma_cty, ma_ct) an toàn.
  */
 class SiDmCt extends SModel
 {
-    public $incrementing  = false;
-    public $timestamps    = false;
-    protected $table      = 'SiDmCt';
-    protected $primaryKey = 'ma_ct';
-    protected $keyType    = 'string';
-
-    protected $fillable = [
-        'ma_cty',
-        'ma_ct',
-        'phan_he',
-        'ma_ct_me',
-        'ten_ct',
-        'tk_no',
-        'tk_co',
-        'ma_nt',
-        'so_lien',
-        'stt_nkc',
-        'stt_ntxt',
-        'ct_dc',
-        'loc_nsd',
-        'vv',
-        'spct',
-        'phi',
-        'bp',
-        'lo',
-        'sp_post',
-        'sp_process',
-        'ph',
-        'ct',
-        'sd',
-        'nxt',
-        'menuid',
-        'vn_prefix',
-        'vn_postfix',
-        'vn_sequence',
-        'vn_pattern',
-        'vn_width',
-        'PhFieldlist2IN',
-        'CtFieldlist2IN',
-        'kieu_trung_so_ct',
-        'VoucherGetWhenOpenForm',
-    ];
-
-    protected $casts = [
-        'so_lien'         => 'integer',
-        'stt_nkc'         => 'integer',
-        'stt_ntxt'        => 'integer',
-        'ct_dc'           => 'boolean',
-        'loc_nsd'         => 'boolean',
-        'vv'              => 'boolean',
-        'spct'            => 'boolean',
-        'phi'             => 'boolean',
-        'bp'              => 'boolean',
-        'lo'              => 'boolean',
-        'sd'              => 'boolean',
-        'vn_sequence'            => 'integer',
-        'vn_width'               => 'integer',
-        'kieu_trung_so_ct'       => 'integer',
-        'VoucherGetWhenOpenForm' => 'boolean',
-    ];
+    use HasSimbaCompositeKey;
 
     /**
-     * Scope: find voucher metadata by company and voucher code.
+     * Scope: tìm voucher metadata theo mã công ty + mã chứng từ.
      *
-     * @param mixed $query
+     * @param  \Illuminate\Database\Eloquent\Builder  $query
+     * @return \Illuminate\Database\Eloquent\Builder
      */
     public function scopeVoucher($query, string $maCt, string $maCty = SModel::CTY)
     {
         return $query->where('ma_cty', $maCty)->where('ma_ct', $maCt);
     }
 
     /**
-     * Scope: find voucher metadata by Simba menuid.
+     * Scope: tìm voucher metadata theo menuid.
      *
-     * @param mixed $query
+     * @param  \Illuminate\Database\Eloquent\Builder  $query
+     * @return \Illuminate\Database\Eloquent\Builder
      */
     public function scopeMenuId($query, string $menuId)
     {
         return $query->where('menuid', $menuId);
     }
 
     /**
+     * Lấy danh sách cột header cho nhập kho từ cột PhFieldlist2IN.
+     *
      * @return list<string>
      */
     public function headerFieldsForInventory(): array
@@ -112,10 +62,12 @@ public function headerFieldsForInventory(): array
     }
 
     /**
+     * Lấy danh sách cột detail cho nhập kho từ cột CtFieldlist2IN.
+     *
      * @return list<string>
      */
     public function detailFieldsForInventory(): array
     {
         return array_values(array_filter(array_map('trim', explode(',', (string) $this->CtFieldlist2IN))));
     }
-}
+}

src/Models/SysDictionaryInfo.php

@@ -8,64 +8,26 @@
  * @author     Tran Ngoc Duc <ductn@diepxuan.com>
  * @author     Tran Ngoc Duc <caothu91@gmail.com>
  *
- * @lastupdate 2026-06-05 20:58:00
+ * @lastupdate 2026-06-21
  */
 
 namespace Diepxuan\Simba\Models;
 
-use Illuminate\Database\Eloquent\Model;
+use Diepxuan\Simba\SModel\sysDictionaryInfoModel as SModel;
 
 /**
- * SimbaERP sysDictionaryInfo table model.
+ * SimbaERP sysDictionaryInfo model.
  *
  * Source: simba-docs/tables/sysDictionaryInfo.md.
+ *
+ * Schema (table, primaryKey, keyType, fillable, casts, timestamps) is owned
+ * by `sysDictionaryInfoModel`; this class only adds Simba-level helpers.
  */
-class SysDictionaryInfo extends Model
+class SysDictionaryInfo extends SModel
 {
-    public $incrementing  = false;
-    public $timestamps    = false;
-    protected $connection = 'sqlsrv';
-    protected $table      = 'sysDictionaryInfo';
-    protected $primaryKey = 'code_name';
-    protected $keyType    = 'string';
-
-    protected $fillable = [
-        'code_name',
-        'PK',
-        'code_fname',
-        'code_length',
-        'name_fname',
-        'table_name',
-        'menuid',
-        'lookup_when_invalid',
-        'allow_merge_code',
-        'dllname',
-        'view_class_name',
-        'edit_class_name',
-        'carry_field_list',
-        'default_sort',
-        'copy_vaora',
-        'par0',
-        'par1',
-        'par2',
-        'par3',
-        'par4',
-        'par5',
-        'par6',
-        'par7',
-        'par8',
-        'par9',
-        'description',
-    ];
-
-    protected $casts = [
-        'code_length'         => 'integer',
-        'lookup_when_invalid' => 'boolean',
-        'allow_merge_code'    => 'boolean',
-        'copy_vaora'          => 'boolean',
-    ];
-
     /**
+     * Lấy danh sách cột khóa chính từ cột PK (chuỗi phân tách bằng dấu phẩy).
+     *
      * @return list<string>
      */
     public function primaryKeyFields(): array
@@ -74,6 +36,8 @@ public function primaryKeyFields(): array
     }
 
     /**
+     * Lấy danh sách cột carry từ cột carry_field_list.
+     *
      * @return list<string>
      */
     public function carryFields(): array
@@ -82,22 +46,24 @@ public function carryFields(): array
     }
 
     /**
-     * Scope: find dictionary metadata by Simba code_name.
+     * Scope: tìm dictionary metadata theo code_name.
      *
-     * @param mixed $query
+     * @param  \Illuminate\Database\Eloquent\Builder  $query
+     * @return \Illuminate\Database\Eloquent\Builder
      */
     public function scopeCodeName($query, string $codeName)
     {
         return $query->where('code_name', $codeName);
     }
 
     /**
-     * Scope: find dictionary metadata by Simba menuid.
+     * Scope: tìm dictionary metadata theo menuid.
      *
-     * @param mixed $query
+     * @param  \Illuminate\Database\Eloquent\Builder  $query
+     * @return \Illuminate\Database\Eloquent\Builder
      */
     public function scopeMenuId($query, string $menuId)
     {
         return $query->where('menuid', $menuId);
     }
-}
+}

src/Models/SysReportDrillDownInfo.php

@@ -2,17 +2,29 @@
 
 declare(strict_types=1);
 
+/*
+ * @copyright  © 2019 Dxvn, Inc.
+ *
+ * @author     Tran Ngoc Duc <ductn@diepxuan.com>
+ *
+ * @lastupdate 2026-06-21
+ */
+
 namespace Diepxuan\Simba\Models;
 
-use Diepxuan\Simba\SModel\SModel;
+use Diepxuan\Simba\Models\Concerns\HasSimbaCompositeKey;
+use Diepxuan\Simba\SModel\sysReportDrillDownInfoModel as SModel;
 
+/**
+ * SimbaERP sysReportDrillDownInfo model.
+ *
+ * Source: simba-docs/tables/sysReportDrillDownInfo.md.
+ *
+ * Schema nằm trọn ở `sysReportDrillDownInfoModel`. Model này chỉ bổ sung
+ * `HasSimbaCompositeKey` để thao tác theo composite primary key
+ * (menuid, ma_mau, press_key_name) an toàn.
+ */
 class SysReportDrillDownInfo extends SModel
 {
-    public $incrementing = false;
-    public $timestamps = false;
-    protected $table = 'sysReportDrillDownInfo';
-    protected $primaryKey = 'menuid';
-    protected $keyType = 'string';
-
-    protected $fillable = ['menuid','ma_mau','press_key_name','drilldown_menuid','drilldown_menuid1','drilldown_menuid2','drilldown_menuid3','drilldown_menuid4','dllName','command','description','par0','par1','par2','par3','par4','par5','par6','par7','par8','par9'];
-}
+    use HasSimbaCompositeKey;
+}

src/Models/SysReportInfo.php

@@ -2,24 +2,29 @@
 
 declare(strict_types=1);
 
+/*
+ * @copyright  © 2019 Dxvn, Inc.
+ *
+ * @author     Tran Ngoc Duc <ductn@diepxuan.com>
+ *
+ * @lastupdate 2026-06-21
+ */
+
 namespace Diepxuan\Simba\Models;
 
-use Diepxuan\Simba\SModel\SModel;
+use Diepxuan\Simba\Models\Concerns\HasSimbaCompositeKey;
+use Diepxuan\Simba\SModel\sysReportInfoModel as SModel;
 
+/**
+ * SimbaERP sysReportInfo model.
+ *
+ * Source: simba-docs/tables/sysReportInfo.md.
+ *
+ * Schema nằm trọn ở `sysReportInfoModel`. Model này chỉ bổ sung
+ * `HasSimbaCompositeKey` để thao tác theo composite primary key
+ * (menuid, ma_mau) an toàn.
+ */
 class SysReportInfo extends SModel
 {
-    public $incrementing = false;
-    public $timestamps = false;
-    protected $table = 'sysReportInfo';
-    protected $primaryKey = 'menuid';
-    protected $keyType = 'string';
-
-    protected $fillable = ['menuid','ma_mau','ctlclass','spname','rptname','isdefault','bang_chu','bang_chu0','hasNT','dynReportFields','par0','par1','par2','par3','par4','par5','par6','par7','par8','par9','description_colname'];
-
-    protected $casts = [
-        'isdefault' => 'boolean',
-        'bang_chu' => 'boolean',
-        'bang_chu0' => 'boolean',
-        'hasNT' => 'boolean',
-    ];
-}
+    use HasSimbaCompositeKey;
+}