Merge pull request #147 from diepxuan/refactor/remove-dead-code-procedurecaller

fix: UTF-8 parameter binding in ProcedureCaller + remove dead code

Author: caothu159

src/StoredProcedures/ProcedureCaller.php

@@ -8,7 +8,7 @@
  * @author     Tran Ngoc Duc <ductn@diepxuan.com>
  * @author     Tran Ngoc Duc <caothu91@gmail.com>
  *
- * @lastupdate 2026-04-07 12:39:39
+ * @lastupdate 2026-04-07 13:04:50
  */
 
 namespace Diepxuan\Simba\StoredProcedures;
@@ -87,7 +87,7 @@ public static function call(string $name, array $params = [], ?string $connectio
         if (empty($bindings)) {
             $rows = $conn->select($sql);
         } else {
-            // Replace ? với Unicode literal
+            // Replace :placeholder với Unicode literal (fix UTF-8 cho SQL Server)
             $processedQuery = self::replacePlaceholders($sql, $bindings);
             $rows           = $conn->select($processedQuery);
         }
@@ -146,41 +146,20 @@ public static function toUnicodeLiteral(mixed $value): string
     }
 
     /**
-     * Replace ? placeholders với Unicode literals.
+     * Replace :placeholder với Unicode literals (N'...')
+     * Fix UTF-8 cho SQL Server parameter binding trên Linux.
+     *
+     * @param string $query    SQL query với :named placeholders
+     * @param array  $bindings Associative array [paramName => value]
      */
     private static function replacePlaceholders(string $query, array $bindings): string
     {
-        $count = 0;
-
-        return preg_replace_callback('/\?/', static function () use ($bindings, &$count) {
-            $value = $bindings[$count] ?? null;
-            ++$count;
-
-            return self::toUnicodeLiteral($value);
-        }, $query);
-    }
-
-    /**
-     * Kiểm tra xem value có phải là date/datetime format không.
-     */
-    private static function isDateOrDatetime(string $value): bool
-    {
-        // Check các format date/datetime phổ biến
-        // YYYY-MM-DD, YYYY-MM-DD HH:MM:SS, DD/MM/YYYY, v.v.
-        $datePatterns = [
-            '/^\d{4}-\d{2}-\d{2}$/',                    // 2026-04-06
-            '/^\d{4}-\d{2}-\d{2} \d{2}:\d{2}:\d{2}$/',  // 2026-04-06 12:30:45
-            '/^\d{4}-\d{2}-\d{2}T\d{2}:\d{2}:\d{2}$/',  // 2026-04-06T12:30:45 (ISO 8601)
-            '/^\d{2}\/\d{2}\/\d{4}$/',                  // 06/04/2026
-            '/^\d{2}-\d{2}-\d{4}$/',                    // 06-04-2026
-        ];
-
-        foreach ($datePatterns as $pattern) {
-            if (preg_match($pattern, $value)) {
-                return true;
-            }
+        foreach ($bindings as $key => $value) {
+            $literal = self::toUnicodeLiteral($value);
+            $pattern = '/:' . preg_quote($key, '/') . '/';
+            $query   = preg_replace($pattern, $literal, $query);
         }
 
-        return false;
+        return $query;
     }
 }