fix: improve submodule sync in gh-pages worktree - #39
Merged
Conversation
The previous fix added git submodule sync but submodules still weren't detected by git add -A. Root cause: after git rm removes submodules from the index, git add -A does not re-add them as new submodule entries. Fix: explicitly 'git add src/' after initializing and checking out submodule refs, forcing git to register them in the index. Also simplify the sync flow: - cd into worktree once for submodule operations - use git submodule update --init --checkout for clean initialization - add explicit 'git add src/' to register submodule entries in index
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Vấn đề
PR #38 đã thêm
git submodule syncnhưng submodules vẫn không được phát hiện.Root cause
git add -Akhông tự động add submodules mới vào index. Sau khigit rmxóa submodules khỏi index, cầngit add src/rõ ràng để đăng ký lại chúng.Fix
git add src/rõ ràng sau khi init và checkout submodule refsgit submodule update --init --checkoutthay vì--forceLuồng đúng sau fix