Repository navigation
fix: preserve Markdown formatting and allow source-mode repairs - #1255
Merged
Merged
Conversation
MDXEditor clears its initial-normalization flag only in its rich-text export, which a parse error suppresses, so every source edit reached the viewer as normalization and rebased the session clean: Save stayed disabled. Once the editor reports a parse error, its changes count as edits until the next load. Refs #1254
Deploying mouseterm with
|
| Latest commit: |
281d126
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://4cbd9bcf.mouseterm.pages.dev |
| Branch Preview URL: | https://fix-issue-1254.mouseterm.pages.dev |
nedtwigg
changed the title
dormouse-bot
commented
Oct 20, 2026
dormouse-bot
left a comment
dormouse-bot
left a comment
Collaborator
Author
There was a problem hiding this comment.
One finding inline: the entity rewrite in the text handler changes literal < / > text on save. I'm pushing the suggested fix along with a regression test.
…f shadowing it Publish initialMarkdownNormalize$ false from onError rather than keeping a module-level unparsed flag that apply() had to reset. Resolve the format test's MDXEditor dependencies from the viewer, as markdown-dependencies does, and drop an assertion the preceding one already implied. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
nedtwigg
had a problem deploying
to
hosted-preview
October 21, 2026 00:33 — with 
GitHub Actions
Error
GitHub Actions
Error
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1254.
Editing and saving Markdown now keeps simple standalone bracket labels such as
[Unreleased]and[1.3.0], writes literal angle brackets in text as entities so<your relay>survives rich-text/source round trips, and preserves recognized headings' existing blank-line choice. New or renamed headings follow the document's majority spacing. Ambiguous bracket syntax retains the serializer's escapes; links, reference definitions, task-like list text, code, and HTML keep their meaning. This is a small serializer customization, not a lossless Markdown editor.After an import error, the viewer clears MDXEditor's initial-normalization flag so source edits count as edits. Claude's simplify pass removed the duplicate local flag, and dormouse-bot's follow-up preserves text that intentionally spells out numeric entities such as
<. Users can repair the file, save it, and switch back to rich text. The owning spec and rationale now cover both recovery and formatting.Validation:
dor-tools-builtin.pnpm lint:specs,pnpm lint:md, andgit diff --checkpassed.<your relay>fixture, repaired it to entities in source mode, verified Save became enabled, saved, returned to rich text, and reloaded successfully.