Repository navigation
Keep host modifier chords out of pane commands and kill answers - #1278
Merged
Merged
Conversation
Deploying mouseterm with
|
| Latest commit: |
091650a
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://181468da.mouseterm.pages.dev |
| Branch Preview URL: | https://audit-keyboard-modifiers.mouseterm.pages.dev |
dormouse-bot
left a comment
dormouse-bot
left a comment
Collaborator
There was a problem hiding this comment.
The new modifier guard in handlePaneShortcuts also catches | when Option or AltGr typed it, which is how many European layouts produce that character (inline).
nedtwigg
had a problem deploying
to
hosted-preview
October 21, 2026 07:20 — with 
GitHub Actions
Error
GitHub Actions
Error
dormouse-bot
approved these changes
Oct 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Command mode treated modified keys as plain pane actions: Ctrl+X requested a kill, Ctrl+T toggled TODO, and Ctrl+- split a pane. A pane kill prompt could also accept a matching letter inside a host chord, unlike the existing Workspace confirmation.
Leave Cmd/Ctrl/Alt pane-action chords and Alt+Arrow navigation unhandled, preserving the explicit Cmd/Ctrl arrow swaps. Share the Workspace confirmation's answer-key predicate with pane confirmation so modifiers and host chords neither accept nor dismiss it. Shift-produced punctuation and uppercase confirmation letters retain their behavior. Update layout and the shortcut reference.
Validation: 11 regressions failed before the fix. All 266 targeted keyboard, confirmation, and Wall tests pass, including existing swap/backtracking coverage. Library TypeScript, spec lint, Markdown lint, and diff checks pass.
Option/AltGr-produced symbol bindings remain available on international layouts. Four additional regressions reproduced the review finding; all 52 affected keyboard/confirmation tests and the type/spec/Markdown checks pass.