Repository navigation
Cancel quit and close when unsaved-file consent changes scope - #1279
Merged
Merged
Conversation
Deploying mouseterm with
|
| Latest commit: |
a02016c
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://9968a404.mouseterm.pages.dev |
| Branch Preview URL: | https://audit-teardown-consent.mouseterm.pages.dev |
dormouse-bot
left a comment
dormouse-bot
left a comment
Collaborator
There was a problem hiding this comment.
The new membership watch duplicates the running-work dialog's scope check (inline).
dormouse-bot
approved these changes
Oct 21, 2026
nedtwigg
had a problem deploying
to
hosted-preview
October 21, 2026 16:19 — with 
GitHub Actions
Error
GitHub Actions
Error
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An unsaved-file prompt previously outlived changes to the window's Workspace membership. Saving or discarding could then let quit or window close proceed over a different scope than the request began with.
Watch Workspace membership during that first consent gate, cancel on arrivals or departures, and release the watch on every exit. Focus, rename, and reorder preserve consent. The standalone spec now makes the existing cancellation rule explicit for unsaved-file prompts.
Validation: four new regression cases fail before the fix; all 61 quit, close, arbitration, confirmation, and consent tests pass afterward. Standalone TypeScript, spec lint, Markdown lint, and diff checks pass.
Both consent gates now use one Workspace membership watcher, so their scope rules stay aligned. The same 61 tests and standalone type/spec checks pass after consolidation.