Skip to content

Keep clipboard feedback when a pending copy's selection moves - #1280

Merged
nedtwigg merged 1 commit into
mainfrom
audit-copy-selection-identity
Oct 21, 2026
Merged

nedtwigg merged 1 commit into
mainfrom
audit-copy-selection-identity

Conversation

@nedtwigg

Copy link
Copy Markdown
Member

Resizing a terminal while its clipboard write was pending replaced the selection object. The completed write then appeared to belong to a different selection, suppressing both success and failure feedback and leaving successful copies open.

Keep a selection identity through reflow and edge adjustments, and clear it when that selection ends or a new drag starts. Pending writes now report against the original selection without clearing a newer one. The clipboard spec explicitly covers movement during the write.

Validation: both real-xterm resize regressions fail before the fix. All 155 selection, copy editor, lifecycle, reflow, and mouse-router tests pass, including pending edge adjustments and newer-drag protection. Library TypeScript, spec lint, Markdown lint, and diff checks pass.

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Oct 21, 2026 •

Copy link
Copy Markdown

Deploying mouseterm with  Cloudflare Pages  Cloudflare Pages

Latest commit: 0c7c122
Status: ✅  Deploy successful!
Preview URL: https://16cdd864.mouseterm.pages.dev
Branch Preview URL: https://audit-copy-selection-identit.mouseterm.pages.dev

View logs

@nedtwigg
nedtwigg added this pull request to stack #1322 October 21, 2026 15:46
@nedtwigg
nedtwigg merged commit 161d52b into main Oct 21, 2026
18 of 19 checks passed
@nedtwigg
nedtwigg deleted the audit-copy-selection-identity branch October 21, 2026 16:15

This branch was successfully deployed

No deployments
hosted-preview — 0c7c1221 Deployed Oct 21, 2026 by nedtwigg via deploy #1745
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants