Repository navigation
Preserve selections while older scrollback is trimmed - #1281
Merged
nedtwigg merged 3 commits intoOct 21, 2026
Merged
Conversation
Deploying mouseterm with
|
| Latest commit: |
c397727
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://cf222901.mouseterm.pages.dev |
| Branch Preview URL: | https://audit-selection-scrollback.mouseterm.pages.dev |
dormouse-bot
approved these changes
Oct 21, 2026
nedtwigg
had a problem deploying
to
hosted-preview
October 21, 2026 07:43 — with 
GitHub Actions
Error
GitHub Actions
Error
…ollback # Conflicts: # lib/src/lib/mouse-selection.ts
dormouse-bot
approved these changes
Oct 21, 2026
dormouse-bot
approved these changes
Oct 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At the scrollback limit, new output shifts surviving rows toward the start of the buffer. Selection coordinates stayed at the old rows, so still-present text lost its selection. If a trimmed row was replaced by identical text, the opposite happened: a selection survived after its original row was gone.
Follow a marker on the selection's earlier row before comparing its text. Keep the copy editor and any program-provided copy offer while the same cells move; cancel when the selected row is trimmed. This covers linewise, block, and program-owned selections without text searching.
Validation: four real-xterm regressions fail before the fix. All 157 affected selection, reflow, lifecycle, copy editor, overlay, and mouse-router tests pass. Library TypeScript, spec lint, Markdown lint, and diff checks pass.
Stacked on #1280 because both fixes preserve selection state through coordinate changes. Their shared replacement logic is integrated here.