Move exception-to-FailureStatus conversion from speedy to engine - #23323
Open
remyhaemmerle-da wants to merge 3 commits into
Open
Move exception-to-FailureStatus conversion from speedy to engine#23323remyhaemmerle-da wants to merge 3 commits into
remyhaemmerle-da wants to merge 3 commits into
Conversation
paulbrauner-da
approved these changes
Aug 28, 2026
paulbrauner-da
left a comment
paulbrauner-da
left a comment
Contributor
There was a problem hiding this comment.
LGTM for the Runner part. For the safe proto part you may want to have someone from canton who understand how these safe proto fields are supposed to be handled to have a look.
I think it'd be a good thing for @samuel-williams-da to also have a look at lines 124 to 152 in the runner, in particular the recoverWith part, since I'm not very familiar with this particular free monad implementation.
remyhaemmerle-da
force-pushed
the
remy/failure-status
branch
from
August 28, 2026 10:43
86bcca7 to
dc256db
Compare
Collaborator
Author
|
The safe proto part was part of fixing the SDK. It is gone as @samuel-williams-da push those fix to previous canton update. |
remyhaemmerle-da
added
the
no-release-notes
samuel-williams-da
approved these changes
Aug 28, 2026
samuel-williams-da
left a comment
samuel-williams-da
left a comment
Contributor
There was a problem hiding this comment.
Looks good, from my understanding of the changes, this does not change any behaviour :)
The speedy interpreter now always emits UnhandledException errors; the engine's computeFailureStatus is responsible for calling the exception message function and wrapping the result in FailureStatus.
remyhaemmerle-da
force-pushed
the
remy/failure-status
branch
from
September 1, 2026 11:50
1c01a36 to
66ca9df
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The speedy interpreter now always emits UnhandledException errors; the
engine's computeFailureStatus is responsible for calling the exception
message function and wrapping the result in FailureStatus.
companion PR: https://github.com/DACH-NY/canton/pull/35042
fix #23293