Emit raw error message when API calls fail?

[ww-oai]

Hi there!

I'm trying to diagnose an HTTP 400 I'm seeing from GitLab's API when using this action. Unfortunately, the error message surfaced by this action is pretty opaque:

Error: GitLab API returned status code 400.

That comes from here:

gitlab-pipeline-trigger-action/index.js

Line 56 in b5e35a1

let errorMessage = `GitLab API returned status code ${response.status}.`;

I think this could be improved by dumping the (raw) JSON from the error response. Ideally we'd extract the exact message, but GitLab doesn't seem to do a great job of guaranteeing the shape:

https://docs.gitlab.com/api/rest/troubleshooting/#status-code-400

If that sounds reasonable, I'm happy to send a PR that adds a dump of the JSON when verbose: true is enabled.

[pbek]

That could also expose internal data in CI. 🤔
Opinions, @lazka?

[lazka]

If that sounds reasonable, I'm happy to send a PR that adds a dump of the JSON when verbose: true is enabled.

sounds good

That could also expose internal data in CI. 🤔
Opinions, @lazka?

that's what the verbose switch was added for

[pbek]

Yolo it is then. 👍🏻️😊

[lazka]

The only "real" secret here is the access tokens, and I doubt gitlab would expose them in an error message.

We could pass them through core.setSecret() though, so GH masks them in the logs, might be a good thing to do either way.

[ww-oai]

Yeah, FWICT GitLab won't expose secrets in those error messages. If it did, I think that would be a bounty-worthy security issue 😅