Better error handling in ProjectDB user SQL - #38129
Open
esoergel wants to merge 2 commits into
Open
Conversation
https://dimagi.sentry.io/issues/7718669942/?environment=staging&project=136860&query=is%3Aunresolved age%3A-7d&referrer=issue-stream `sqlglot.parse` returns `None` for empty strings and such
esoergel
changed the title
esoergel
added
the
product/feature-flag
esoergel
marked this pull request as ready for review
September 9, 2026 12:01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Product Description
Catch a couple errors that popped up during testing - both are user errors that just needed to be caught and handled explicitly.
Technical Summary
Commits have a bit more context on each change. Both are pretty straightforward.
Feature Flag
ProjectDB
Safety Assurance
Safety story
Automated test coverage
QA Plan
Rollback instructions
Labels & Review