feat(Manifold.Worker): Allow sends with :noconnect and :nosuspend options - #21
Open
jliklik wants to merge 5 commits into
Open
feat(Manifold.Worker): Allow sends with :noconnect and :nosuspend options#21jliklik wants to merge 5 commits into
jliklik wants to merge 5 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add
:nosuspendand:noconnectoptions when sending to remote nodes.Why
When communicating with an unreliable remote node,
send/2may block or slow down the sending erlang process due to auto-connections and overloaded connections.:nosuspend-> Allows sending process to drop message if connection to the remote node is overloaded:noconnect-> If remote node is not already connected, node will not try to connect to it when sending the messageThese options must be used with care, as they may break the reliable message passing guarantees normally expected in erlang/elixir.
How
Use
Process.send/3with:noconnectand:nosuspendoptions instead ofKernel.send/2.Testing
Added some tests for the new Manifold options and to verify that the new
Process.send/3call does not break functionality.