Skip to content

Fix: Set default event-category color to match the map legend style - #113

Merged
benjaoming merged 3 commits into
django:mainfrom
kehach07:issue-102-fix/default-event-category-style
Nov 15, 2025
Merged

Fix: Set default event-category color to match the map legend style#113
benjaoming merged 3 commits into
django:mainfrom
kehach07:issue-102-fix/default-event-category-style

Conversation

@kehach07

Copy link
Copy Markdown
Contributor

Summary

This PR updates the default .event-category style to use the same background and text color as the "Other" category.
This ensures that any new or undefined event types will automatically inherit the "Other" category’s color scheme.

Changes

  • Set .event-category default background to #222222 and text color to #fafcfb.
  • Ensures consistent styling for future event categories without explicit color definitions.

Why

Previously, if a new event category was added without a defined style, it appeared unstyled or inconsistent.
With this change, such cases will now default to the "Other" color scheme, maintaining visual consistency across the site.

Visual impact

No visible change for existing categories — only affects undefined or future event types.

@kehach07 kehach07 mentioned this pull request Nov 11, 2025

@benjaoming benjaoming left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 I'm not sure the CSS comments help unless you write that by "Other" we mean the legend in the map.

@kehach07 kehach07 changed the title Fix: set default event-category color to match "Other" style Fix: Add default color fallback for event-category Nov 11, 2025
@kehach07

Copy link
Copy Markdown
Contributor Author

@benjaoming thank you sir, I have updated the title as per your suggestion.

@kehach07 kehach07 changed the title Fix: Add default color fallback for event-category Fix: Set default event-category color to match the map legend style Nov 11, 2025
@benjaoming

Copy link
Copy Markdown
Contributor

@kehach07 there is a merge conflict to solve 😊

@benjaoming
benjaoming merged commit 784b07a into django:main Nov 15, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants