Ruff fixes

Author: ulgens

accounts/tests.py

@@ -284,8 +284,10 @@ def test_low_score_rejected(self):
         self.assertEqual(
             logs.output,
             [
-                "WARNING:django_recaptcha.fields:ReCAPTCHA validation failed due to "
-                "its score of 0.1 being lower than the required amount."
+                (
+                    "WARNING:django_recaptcha.fields:ReCAPTCHA validation failed due to "
+                    "its score of 0.1 being lower than the required amount."
+                )
             ],
         )
 

accounts/views.py

@@ -28,7 +28,7 @@ def user_profile(request, username):
 
 @login_required
 def edit_profile(request):
-    profile, created = Profile.objects.get_or_create(user=request.user)
+    profile, _created = Profile.objects.get_or_create(user=request.user)
     form = ProfileForm(request.POST or None, instance=profile)
     if form.is_valid():
         form.save()

aggregator/tests.py

@@ -191,8 +191,10 @@ def test_rejects_stackoverflow_questions(self):
             form.errors,
             {
                 "feed_url": [
-                    "Stack Overflow questions tagged with 'django' will appear "
-                    "here automatically."
+                    (
+                        "Stack Overflow questions tagged with 'django' will appear "
+                        "here automatically."
+                    )
                 ]
             },
         )

checklists/models.py

@@ -399,7 +399,7 @@ def tags(self):
 
     @cached_property
     def latest_release(self):
-        return [r for r in self.affected_releases if not r.is_pre_release][0]
+        return next(r for r in self.affected_releases if not r.is_pre_release)
 
     @cached_property
     def hashes_by_versions(self):

checklists/tests/test_models.py

@@ -75,15 +75,19 @@ def assertMakeReleasePublicAdded(self, release, content):
         self.assertIn(expected, content)
         version = release.version
         data = [
-            "- [ ] Add (or edit if existing) the the [release entry in the admin]"
-            f"(https://www.djangoproject.com/admin/releases/release?version={version})",
+            (
+                "- [ ] Add (or edit if existing) the the [release entry in the admin]"
+                f"(https://www.djangoproject.com/admin/releases/release?version={version})"
+            ),
             "- Is active: False",
             f"- LTS: {release.is_lts}",
             f"- Release date: {release.date.isoformat()}",
             f"- `VERSION={version} scripts/verify_release.sh`",
             "- `twine upload --repository django dist/*`",
-            '- [ ] Mark the release as "active" in\n  '
-            f"https://www.djangoproject.com/admin/releases/release/{version}/change/",
+            (
+                '- [ ] Mark the release as "active" in\n  '
+                f"https://www.djangoproject.com/admin/releases/release/{version}/change/"
+            ),
         ]
         for item in data:
             with self.subTest(item=item):
@@ -500,8 +504,10 @@ def test_render_checklist_affects_prerelease(self):
         cves = checklist.securityissue_set.all()
         prenotification = [
             "Create a new text file `prenotification-email.txt` with content",
-            "a set of security releases will be issued on Wednesday, May 7, 2025 "
-            "around 16:18 UTC",
+            (
+                "a set of security releases will be issued on Wednesday, May 7, 2025 "
+                "around 16:18 UTC"
+            ),
             *(cve.headline_for_blogpost for cve in cves),
             "## Affected supported versions "
             + " ".join(f"* Django {branch}" for branch in checklist.affected_branches),
@@ -609,14 +615,18 @@ def test_render_checklist_headline_formats(self):
 
         # RST security archive uses double backticks and RST-style headings.
         expected_rst = [
-            "May 7, 2025 - :cve:`2025-11111`\n"
-            "-------------------------------\n\n"
-            "Denial-of-service possibility in ``strip_tags()``.\n"
-            f"`Full description\n<{checklist.blogpost_link}>`__",
-            "May 7, 2025 - :cve:`2025-22222`\n"
-            "-------------------------------\n\n"
-            "Denial-of-service in ``LoginView`` and ``LogoutView``.\n"
-            f"`Full description\n<{checklist.blogpost_link}>`__",
+            (
+                "May 7, 2025 - :cve:`2025-11111`\n"
+                "-------------------------------\n\n"
+                "Denial-of-service possibility in ``strip_tags()``.\n"
+                f"`Full description\n<{checklist.blogpost_link}>`__"
+            ),
+            (
+                "May 7, 2025 - :cve:`2025-22222`\n"
+                "-------------------------------\n\n"
+                "Denial-of-service in ``LoginView`` and ``LogoutView``.\n"
+                f"`Full description\n<{checklist.blogpost_link}>`__"
+            ),
         ]
         for headline in expected_rst:
             with self.subTest(headline=headline):
@@ -1220,7 +1230,7 @@ class PreReleaseChecklistTestCase(BaseChecklistTestCaseMixin, TestCase):
 
     def test_affected_releases(self):
         feature_release = self.factory.make_feature_release_checklist("6.0")
-        for status, verbose in self.status_to_version.items():
+        for status in self.status_to_version:
             release = self.factory.make_release(version=f"6.0{status}1")
             with self.subTest(release=release):
                 checklist = self.make_checklist(
@@ -1255,7 +1265,7 @@ def test_blogpost_info(self):
 
     def test_versions(self):
         feature_release = self.factory.make_feature_release_checklist("6.0")
-        for status, verbose in self.status_to_version.items():
+        for status in self.status_to_version:
             version = f"6.0{status}1"
             release = self.factory.make_release(version=version)
             with self.subTest(release=release):
@@ -1342,13 +1352,19 @@ def test_render_checklist(self):
         feature_release_tasks = [
             "- Remove the `UNDER DEVELOPMENT` header at the top of the release notes",
             "- Remove the `Expected` prefix and update the release date if necessary",
-            "- [ ] Create a new branch from the current stable branch in the "
-            "[django-docs-translations repository]",
-            "- [ ] Update the metadata for the docs in "
-            "https://www.djangoproject.com/admin/docs/documentrelease/",
+            (
+                "- [ ] Create a new branch from the current stable branch in the "
+                "[django-docs-translations repository]"
+            ),
+            (
+                "- [ ] Update the metadata for the docs in "
+                "https://www.djangoproject.com/admin/docs/documentrelease/"
+            ),
             "- Create new `DocumentRelease` objects for each language",
-            "- [ ] Extend [robots.docs.txt](https://github.com/django/"
-            "djangoproject.com/blob/main/djangoproject/static/robots.docs.txt)",
+            (
+                "- [ ] Extend [robots.docs.txt](https://github.com/django/"
+                "djangoproject.com/blob/main/djangoproject/static/robots.docs.txt)"
+            ),
             "- [ ] Advance the version in the download page's tables",
             "- [ ] Update the current stable branch and remove the pre-release branch",
             version_trove_classifier_updates,

djangoproject/settings/dev.py

@@ -1,4 +1,4 @@
-from .common import *  # noqa
+from .common import *
 
 ALLOWED_HOSTS = [
     "www.djangoproject.localhost",

djangoproject/settings/docker.py

@@ -1,4 +1,4 @@
-from .dev import *  # noqa: F403
+from .dev import *
 
 DATABASES = {
     "default": {

djangoproject/settings/prod.py

@@ -1,4 +1,4 @@
-from .common import *  # noqa
+from .common import *
 
 DOMAIN_NAME = os.getenv("DOMAIN_NAME", "djangoproject.com")
 

docs/builder.py

@@ -60,7 +60,7 @@ def get_doc_context(self, docname, body, metatags):
         out_dict["python_objects_search"] = " ".join(
             # Keeps the code suffix to improve the search results for terms such as
             # "select" for QuerySet.select_related.
-            [key.split(".")[-1] for key in python_objects.keys()]
+            [key.split(".")[-1] for key in python_objects]
         )
         return out_dict
 

docs/management/commands/build_doc_release.py

@@ -142,7 +142,7 @@ def build_doc_release(self, release):
                 capture_sentry_exception(e, flush=True)
                 raise CommandError(
                     f"sphinx-build returned an error (release {release}, "
-                    f"builder {builder}): {str(e)}"  # noqa: E501
+                    f"builder {builder}): {e!s}"
                 ) from e
 
         #
@@ -212,7 +212,7 @@ def gen_decoded_documents(directory):
     for root, dirs, files in os.walk(str(directory)):
         for f in files:
             f = Path(root, f)
-            if not f.suffix == ".fjson":
+            if f.suffix != ".fjson":
                 continue
 
             with f.open() as fp: