Merge branch 'master' into poc_v2_pragma_lint

Author: gorsing

.circleci/run.sh

@@ -66,7 +66,7 @@ install_deps() {
 
     download "https://dlang.org/install.sh" "https://nightlies.dlang.org/install.sh" "install.sh"
 
-    source "$(CURL_USER_AGENT=\"$CURL_USER_AGENT\" bash install.sh dmd-$HOST_DMD_VER --activate)"
+    source "$(CURL_USER_AGENT="$CURL_USER_AGENT" bash install.sh dmd-$HOST_DMD_VER --activate)"
     $DC --version
     env
     deactivate
@@ -109,7 +109,7 @@ setup_repos() {
 coverage()
 {
     # load environment for bootstrap compiler
-    source "$(CURL_USER_AGENT=\"$CURL_USER_AGENT\" bash ~/dlang/install.sh dmd-$HOST_DMD_VER --activate)"
+    source "$(CURL_USER_AGENT="$CURL_USER_AGENT" bash ~/dlang/install.sh dmd-$HOST_DMD_VER --activate)"
 
     local build_path=generated/linux/$BUILD/$MODEL
     local builder=generated/build
@@ -172,7 +172,7 @@ check_d_builder()
 {
     echo "Testing D build"
     # load environment for bootstrap compiler
-    source "$(CURL_USER_AGENT=\"$CURL_USER_AGENT\" bash ~/dlang/install.sh dmd-$HOST_DMD_VER --activate)"
+    source "$(CURL_USER_AGENT="$CURL_USER_AGENT" bash ~/dlang/install.sh dmd-$HOST_DMD_VER --activate)"
     ./compiler/src/build.d clean
     rm -rf generated # just to be sure
     # TODO: add support for 32-bit builds
@@ -186,7 +186,7 @@ check_d_builder()
 test_cxx()
 {
     # load environment for bootstrap compiler
-    source "$(CURL_USER_AGENT=\"$CURL_USER_AGENT\" bash ~/dlang/install.sh dmd-$HOST_DMD_VER --activate)"
+    source "$(CURL_USER_AGENT="$CURL_USER_AGENT" bash ~/dlang/install.sh dmd-$HOST_DMD_VER --activate)"
     echo "Test CXX frontend.h header generation"
     ./compiler/src/build.d
     make -j$N -C druntime MODEL=$MODEL BUILD=$BUILD

.pre-commit-config.yaml

@@ -21,7 +21,7 @@ repos:
   - id: detect-private-key
   - id: no-commit-to-branch
     args: [--branch, master]
-- repo: https://github.com/sirosen/check-jsonschema
-  rev: 0.34.1
+- repo: https://github.com/python-jsonschema/check-jsonschema
+  rev: 0.37.1
   hooks:
     - id: check-github-workflows

changelog/dmd.atomic.dd

@@ -0,0 +1,24 @@
+Shared static constructors/destructors in templates now lower to `object._d_atomicOp`
+
+When a shared static constructor or destructor appears inside a template, it may
+be instantiated in multiple modules, causing it to run multiple times. A shared
+gate variable is used to count and guard executions, ensuring the body runs
+exactly once across all modules. The atomic operation on that gate is necessary
+because multiple threads may initialize modules concurrently.
+
+This gate operation previously called `core.atomic.atomicOp` directly.
+
+---
+shared static this()
+{
+    if (atomicOp!"+="(gate, 1) != 1) return;
+    // inside a template instantiation
+}
+---
+
+It now lowers to `object._d_atomicOp`, consistent with how other compiler-generated
+runtime hooks are handled.
+
+---
+if (.object._d_atomicOp!"+="(gate, 1) != 1) return;
+---

changelog/dmd.foreach-shadow-error.dd

@@ -0,0 +1,32 @@
+Foreach variable shadowing is now an error
+
+A deprecation introduced in DMD 2.089.0 for foreach variables shadowing
+outer scope symbols has been upgraded to an error.
+
+This affects both variables declared inside a foreach body that shadow
+outer variables, and duplicate variable names in foreach parameter lists
+when using `opApply`.
+
+---
+void main()
+{
+    int[int] arr;
+    int x;
+    foreach (i, j; arr)
+    {
+        int x; // Error: variable `x` is shadowing variable `...x`
+    }
+}
+---
+
+---
+struct Foo
+{
+    int opApply(scope int delegate(size_t, size_t, ref uint)) => 0;
+}
+
+void main()
+{
+    foreach (x, y, x; Foo()) {} // Error: variable `x` is shadowing variable `...x`
+}
+---

changelog/dmd.ftime-trace-inline.dd

@@ -0,0 +1,9 @@
+`-ftime-trace`: add instrumentation for the inliner pass
+
+The `-ftime-trace` output previously had no coverage for the inliner pass.
+When compiling with `-inline`, the time spent scanning and inlining functions
+did not appear in the trace at all.
+
+Two new spans are now emitted: `Inlining` covers the entire inliner pass, and
+`Inline: <function>` covers each function scanned individually.
+These are visible in trace viewers like $(LINK2 https://ui.perfetto.dev/, Perfetto).

changelog/dmd.ftime-trace-sema-subspans.dd

@@ -0,0 +1,9 @@
+`-ftime-trace`: break up the template instance span into sub-phases
+
+The `-ftime-trace` output previously showed template instantiation as a single
+flat block, making it hard to tell where the time was actually going.
+
+The `Sema1: Template Instance` span now contains sub-spans for each phase:
+`Sema1: Template Arg Semantic`, `Sema1: Overload Resolution`,
+`Sema1: Template Members`, `Sema2: Template Instance`, and `Sema3: Template Instance`.
+These are visible in trace viewers like $(LINK2 https://ui.perfetto.dev/, Perfetto).

changelog/dmd.named-args-ifti.dd

@@ -0,0 +1,32 @@
+Implicit Function Template Instantiation (IFTI) handled named arguments better
+
+https://github.com/dlang/dmd/issues/21335
+https://github.com/dlang/dmd/issues/22878
+
+When calling a function template with named arguments, parameters that are
+skipped (because their named argument was not provided) now correctly use
+their template parameter defaults for type deduction.
+
+---
+void f(A = int, B = int)(A a = A.init, B b = B.init) {}
+
+void main()
+{
+    f(b: "hello"); // A = int (template default), B = string (deduced)
+}
+---
+
+Named arguments that appear behind variadic arguments can now be assigned to:
+
+---
+void error(T...)(T args, string file = __FILE__, int line = __LINE__) {}
+
+auto text(T...)(T args, Allocator alloc) {}
+
+void foo(Allocator gc)
+{
+    error("Code: ", code, file: __FILE__, line: __LINE__)
+
+    return text("hello", "world", alloc: gc);
+}
+---

changelog/dmd.timerfd.dd

@@ -0,0 +1,10 @@
+core.sys.linux.timerfd moved to core.sys.linux.sys.timerfd
+
+Usually, a linux header that's included in C like `#include <sys/time.h>` gets its translation in `core/sys/linux/sys/time.d`.
+timerfd.d was an exception, not being put in the `sys` package.
+The module has been moved there, and the old module still exists as a deprecated module that publicly imports the new module.
+
+---
+import core.sys.linux.timerfd; // deprecated
+import core.sys.linux.sys.timerfd; // corrective action
+---

compiler/src/build.d

@@ -1596,7 +1596,7 @@ auto sourceFiles()
         "),
         backendHeaders: fileArray(env["C"], "
             cc.d cdef.d cgcv.d code.d dt.d el.d global.d
-            obj.d oper.d rtlsym.d iasm.d codebuilder.d
+            obj.d oper.d iasm.d codebuilder.d
             ty.d type.d dlist.d
             dwarf.d dwarf2.d cv4.d
             melf.d mscoff.d mach.d
@@ -1639,7 +1639,7 @@ auto sourceFiles()
             dout.d inliner.d eh.d aarray.d
             gloop.d cgelem.d cgcs.d ee.d blockopt.d mem.d cg.d
             dtype.d debugprint.d fp.d symbol.d symtab.d elem.d dcode.d cgsched.d
-            pdata.d util2.d var.d backconfig.d drtlsym.d ptrntab.d
+            pdata.d util2.d var.d backconfig.d rtlsym.d ptrntab.d
             dvarstats.d cgen.d goh.d barray.d cgcse.d elpicpie.d
             dwarfeh.d dwarfdbginf.d cv8.d dcgcv.d
             machobj.d elfobj.d mscoffobj.d

compiler/src/dmd/access.d

@@ -50,7 +50,7 @@ bool checkAccess(AggregateDeclaration ad, Loc loc, Scope* sc, Dsymbol smember)
 
     if (!symbolIsVisible(sc, smember))
     {
-        error(loc, "%s `%s` %s `%s` is not accessible", ad.kind(), ad.toPrettyChars(), smember.kind(), smember.toChars());
+        error(loc, "%s `%s` %s `%s` is not accessible", ad.kind(), ad.toPrettyChars(), smember.kind(), smember.toErrMsg());
         //printf("smember = %s %s, vis = %d, semanticRun = %d\n",
         //        smember.kind(), smember.toPrettyChars(), smember.visible() smember.semanticRun);
         return true;