remove tip()

Author: WalterBright

compiler/include/dmd/errors.h

@@ -20,8 +20,7 @@ enum class ErrorKind
     warning = 0,
     deprecation = 1,
     error = 2,
-    tip = 3,
-    message = 4,
+    message = 3,
 };
 
 #if defined(__GNUC__)
@@ -40,7 +39,6 @@ D_ATTRIBUTE_FORMAT(4, 5) void error(const char *filename, unsigned linnum, unsig
 D_ATTRIBUTE_FORMAT(2, 3) void errorSupplemental(Loc loc, const char *format, ...);
 D_ATTRIBUTE_FORMAT(1, 2) void message(const char *format, ...);
 D_ATTRIBUTE_FORMAT(2, 3) void message(Loc loc, const char *format, ...);
-D_ATTRIBUTE_FORMAT(1, 2) void tip(const char *format, ...);
 
 #if defined(__GNUC__) || defined(__clang__)
 #define D_ATTRIBUTE_NORETURN __attribute__((noreturn))

compiler/src/dmd/dtemplate.d

@@ -938,7 +938,7 @@ extern (C++) class TemplateInstance : ScopeDsymbol
                     return &errorSupplemental;
                 case Classification.deprecation:
                     return &deprecationSupplemental;
-                case Classification.gagged, Classification.tip, Classification.warning:
+                case Classification.gagged, Classification.warning:
                     assert(0);
             }
         }();

compiler/src/dmd/errors.d

@@ -100,7 +100,7 @@ class ErrorSinkCompiler : ErrorSink
     }
 
     // SourceLoc-taking entry points used directly by `error(filename,linnum,...)`,
-    // `errorBackend`, `tip()` and supplemental sites; also called by the Loc
+    // `errorBackend` and supplemental sites; also called by the Loc
     // overloads above.
 
     final void verror(const SourceLoc loc, const(char)* format, va_list ap)
@@ -175,13 +175,6 @@ class ErrorSinkCompiler : ErrorSink
         emit(loc, format, ap, ErrorKind.message, false, false);
     }
 
-    final void vtip(const(char)* format, va_list ap)
-    {
-        if (global.gag)
-            return;
-        emit(SourceLoc.init, format, ap, ErrorKind.tip, false, false);
-    }
-
     final void verrorSupplemental(const SourceLoc loc, const(char)* format, va_list ap)
     {
         if (global.gag)
@@ -233,7 +226,7 @@ class ErrorSinkCompiler : ErrorSink
      *      loc          = location of the diagnostic
      *      format       = printf-style format string
      *      ap           = arguments for `format`
-     *      kind         = error / warning / deprecation / tip / message
+     *      kind         = error / warning / deprecation / message
      *      supplemental = follow-on note, not a primary diagnostic
      *      gagged       = diagnostic occurred under speculative gagging
      */
@@ -269,7 +262,6 @@ private Classification classificationFor(ErrorKind kind) @safe @nogc pure nothro
         case ErrorKind.error:       return Classification.error;
         case ErrorKind.warning:     return Classification.warning;
         case ErrorKind.deprecation: return Classification.deprecation;
-        case ErrorKind.tip:         return Classification.tip;
         case ErrorKind.message:     return Classification.error; // unused (handled above)
     }
 }
@@ -284,7 +276,6 @@ enum Classification : Color
     gagged = Color.brightBlue,        /// for gagged errors
     warning = Color.brightYellow,     /// for warnings
     deprecation = Color.brightCyan,   /// for deprecations
-    tip = Color.brightGreen,          /// for tip messages
 }
 
 
@@ -573,30 +564,6 @@ alias DiagnosticHandler = bool delegate(const ref SourceLoc location, Color head
  */
 __gshared DiagnosticHandler diagnosticHandler;
 
-/**
- * Print a tip message with the prefix and highlighting.
- * Params:
- *      format = printf-style format specification
- *      ...    = printf-style variadic arguments
- */
-static if (__VERSION__ < 2092)
-    extern (C++) void tip(const(char)* format, ...)
-    {
-        va_list ap;
-        va_start(ap, format);
-        global.errorSink.vtip(format, ap);
-        va_end(ap);
-    }
-else
-    pragma(printf) extern (C++) void tip(const(char)* format, ...)
-    {
-        va_list ap;
-        va_start(ap, format);
-        global.errorSink.vtip(format, ap);
-        va_end(ap);
-    }
-
-
 // Encapsulates a diagnostic as described by its location, format message, and kind.
 private struct DiagnosticContext
 {
@@ -636,7 +603,6 @@ private void printDiagnostic(const(char)* format, va_list ap, ref DiagnosticCont
             case ErrorKind.error:       header = "Error: "; break;
             case ErrorKind.deprecation: header = "Deprecation: "; break;
             case ErrorKind.warning:     header = "Warning: "; break;
-            case ErrorKind.tip:         header = "  Tip: "; break;
             case ErrorKind.message:     assert(0);
         }
     }

compiler/src/dmd/errorsink.d

@@ -21,7 +21,6 @@ enum ErrorKind
     warning,
     deprecation,
     error,
-    tip,
     message,
 }
 

compiler/src/dmd/sarif.d

@@ -36,7 +36,6 @@ private string errorKindToString(ErrorKind kind) nothrow
         case ErrorKind.error: return "error";
         case ErrorKind.warning: return "warning";
         case ErrorKind.deprecation: return "note";
-        case ErrorKind.tip: return "note";
         case ErrorKind.message: return "none";
     }
 }