Skip to content

The definition value of DTM_SETFORMATW is incorrect. #22712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thewilsonator merged 2 commits into from
Sep 5, 2026
+1 −1
Merged

The definition value of DTM_SETFORMATW is incorrect. #22712

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
62dfa3b
The definition value of DTM_SETFORMATW is incorrect.
Rayerd Mar 8, 2026
6f4adf5
Merge branch 'dlang:master' into Branch_commctrl.d
Rayerd Sep 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion druntime/src/core/sys/windows/commctrl.d
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2196,7 +2196,7 @@ enum {
DTM_GETMONTHCAL = 0x1008,
DTM_SETMCFONT = 0x1009,
DTM_GETMCFONT = 0x100a,
DTM_SETFORMATW = 0x1050
DTM_SETFORMATW = 0x1032

@thewilsonator thewilsonator Mar 8, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if the original is defined as DTM_FIRST + 50 just write that so that it is a direct translation.

@Rayerd Rayerd Mar 8, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there code in druntime that generates core.sys.windows.* from MinGW? Also, is that MinGW code in this repository?

@rainers rainers Sep 5, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIRC the mingw headers were converted to D more or less manually. Ancient mingw versions contain this bug, but also were formatted like this, while newer (fixed) versions use expressions similar to the SDK. So I think using the old style should be ok.

}

static if (_WIN32_WINNT >= 0x600) {
Expand Down
Loading