fix #17952 - Invalid printf checks for long double on windows - #23733
Merged
Conversation
The MS runtime doesn't support real if larger than double.
thewilsonator
approved these changes
Aug 28, 2026
Member
Author
|
LDC will probably have to tweak the tests a bit, because it has real == double. There is no condition "windows but not LDC" for text replacement, though. |
…ulting to DigitalMars compiler
Contributor
|
Paranoidal: maybe identity of version(Windows)
{
bool isRealIdenticalToDouble = (
real.mant_dig == double.mant_dig
&& real.min_exp == double.min_exp
&& real.max_exp == double.max_exp
)
}? |
Member
Author
That would test the host compiler, not the target to build for. The current target information is not that detailed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The MS runtime doesn't support real if it is larger than double.
Is there a better option for portable code than to always use
cast(c_long_double)for reals?FYI: @denizzzka