Skip to content

add pragma(printf) to ErrorSink functions #23737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thewilsonator merged 1 commit into from
Aug 28, 2026
+69 −1
Merged

add pragma(printf) to ErrorSink functions #23737

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
68 changes: 68 additions & 0 deletions compiler/src/dmd/errorsink.d
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,8 @@ abstract class ErrorSink
void vdeprecation(Loc loc, const(char)* format, va_list ap);
void vdeprecationSupplemental(Loc loc, const(char)* format, va_list ap);

static if (__VERSION__ < 2092)
{
void error(Loc loc, const(char)* format, ...)
{
va_list ap;
Expand Down Expand Up @@ -96,6 +98,72 @@ abstract class ErrorSink
vdeprecationSupplemental(loc, format, ap);
va_end(ap);
}
}
else
{
pragma(printf)
void error(Loc loc, const(char)* format, ...)
{
va_list ap;
va_start(ap, format);
verror(loc, format, ap);
va_end(ap);
}

pragma(printf)
void errorSupplemental(Loc loc, const(char)* format, ...)
{
va_list ap;
va_start(ap, format);
verrorSupplemental(loc, format, ap);
va_end(ap);
}

pragma(printf)
void warning(Loc loc, const(char)* format, ...)
{
va_list ap;
va_start(ap, format);
vwarning(loc, format, ap);
va_end(ap);
}

pragma(printf)
void warningSupplemental(Loc loc, const(char)* format, ...)
{
va_list ap;
va_start(ap, format);
vwarningSupplemental(loc, format, ap);
va_end(ap);
}

pragma(printf)
void message(Loc loc, const(char)* format, ...)
{
va_list ap;
va_start(ap, format);
vmessage(loc, format, ap);
va_end(ap);
}

pragma(printf)
void deprecation(Loc loc, const(char)* format, ...)
{
va_list ap;
va_start(ap, format);
vdeprecation(loc, format, ap);
va_end(ap);
}

pragma(printf)
void deprecationSupplemental(Loc loc, const(char)* format, ...)
{
va_list ap;
va_start(ap, format);
vdeprecationSupplemental(loc, format, ap);
va_end(ap);
}
}

/**
* This will be called to indicate compilation has either
Expand Down
2 changes: 1 addition & 1 deletion compiler/src/dmd/targetcompiler.d
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,7 +215,7 @@ mixin template HostObjectNotFound()
else version (MARS)
{
eSink.errorSupplemental(loc, "dmd might not be correctly installed. Run 'dmd -man' for installation instructions.");
eSink.errorSupplemental(loc, "config file: %.*s", configFile.length, configFile.ptr);
eSink.errorSupplemental(loc, "config file: %.*s", cast(int)configFile.length, configFile.ptr);
}
else
static assert(0, "unknown compiler being built");
Expand Down
Loading