Skip to content

Fix some bugs in fast dfa's borrow checker logic - #23752

Merged
thewilsonator merged 1 commit into
dlang:masterfrom
rikkimax:fastdfa-fix-borrowcheck
Aug 30, 2026
Merged

Fix some bugs in fast dfa's borrow checker logic#23752
thewilsonator merged 1 commit into
dlang:masterfrom
rikkimax:fastdfa-fix-borrowcheck

Conversation

@rikkimax

Copy link
Copy Markdown
Contributor

Thanks to @ntrel for finding these bugs!

@github-actions

Copy link
Copy Markdown

DMD perf check

Metric Base PR Δ
compile dmd itself (wall) 12.4 s 12.6 s +2.14%
All measurements
Metric Base PR Δ
compile hello.d (instr) 214.9 M 214.9 M -0.001%
compile hello.d -O -release (instr) 233.2 M 233.2 M -0.001%
compile Phobos (instr) 5,123.5 M 5,123.2 M -0.006%
compile Phobos codegen (instr) 1,472.6 M 1,472.5 M -0.010%
compile vibe.d (instr) 15,129.9 M 15,129.8 M -0.001%
dmd binary size (stripped) 6.86 MB 6.87 MB +0.06%
hello binary size (stripped) 0.72 MB 0.72 MB 0.00%
peak RSS (compile hello.d) 43.42 MB 43.41 MB -0.02%
peak RSS (compile Phobos) 618.7 MB 617.4 MB -0.20%
peak RSS (compile vibe.d) 1918 MB 1917 MB -0.06%
compile dmd itself (wall) 12.4 s 12.6 s +2.14%
compile hello.d (wall) 66.7 ms 65.7 ms -1.52%
compile Phobos (wall) 1,581 ms 1,600 ms +1.20%

734bc18 vs merge-base 1906158 · about these metrics

@thewilsonator
thewilsonator merged commit 360a367 into dlang:master Aug 30, 2026
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants