remove some dependence on errors.d - #23757
Merged
Merged
Conversation
WalterBright
added
Review:Easy Review
Severity:Refactoring
thewilsonator
approved these changes
Aug 31, 2026
thewilsonator
pushed a commit
that referenced
this pull request
Sep 3, 2026
One of #23757 #23758 #23759 introduced forward reference regression when compiling dmd one module at a time. Remove the problematic import to break the cycle. ``` dmd/errors.d:227:1: error: enum dmd.errors.Classification is forward referenced when looking for 'error' 227 | enum Classification : Color | ^ dmd/dtemplate.d:924:70: error: no property 'error' for type 'Classification'. Did you mean 'Classification.error' ? 924 | extern(D) final void printInstantiationTrace(Classification cl = Classification.error, | ^ dmd/dtemplate.d:1130:27: error: function dmd.dtemplate.TemplateMixin.kind does not override any function 1130 | override const(char)* kind() const | ^ dmd/dtemplate.d:1135:19: error: function dmd.dtemplate.TemplateMixin.accept does not override any function 1135 | override void accept(Visitor v) | ^ ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.