Skip to content

Improve fast dfa so borrow checker supports ternary and if statements - #23761

Merged
thewilsonator merged 1 commit into
dlang:masterfrom
rikkimax:fastdfa-byref-local
Sep 2, 2026
Merged

Improve fast dfa so borrow checker supports ternary and if statements#23761
thewilsonator merged 1 commit into
dlang:masterfrom
rikkimax:fastdfa-byref-local

Conversation

@rikkimax

@rikkimax rikkimax commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Improvements to fast dfa's support of by-ref function local variables, needed for borrow checker.

@rikkimax

rikkimax commented Sep 1, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

buildkite failing due to ldc:

<html>
<body>
<!--StartFragment-->
llvm-config: unknown component name: windowsdriver
--
  | CMake Error at cmake/Modules/FindLLVM.cmake:62 (message):
  | Failed to execute llvm-config ('/bin/llvm-config', result code: '1)'
  | Call Stack (most recent call first):
  | cmake/Modules/FindLLVM.cmake:121 (_LLVM_FAIL)
  | cmake/Modules/FindLLVM.cmake:157 (llvm_set_libs)
  | CMakeLists.txt:32 (find_package)
  |  
  |  
  | -- Configuring incomplete, errors occurred!

<!--EndFragment-->
</body>
</html>

Engine is not on by default, so no failures are expected in CI.

@github-actions

github-actions Bot commented Sep 1, 2026 •
edited
Loading

Copy link
Copy Markdown

DMD perf check

Metric Base PR Δ
dmd binary size (stripped) 6.86 MB 6.88 MB +0.23%
All measurements
Metric Base PR Δ
compile hello.d (instr) 214.9 M 214.9 M -0.002%
compile hello.d -O -release (instr) 233.2 M 233.2 M +0.002%
compile Phobos (instr) 5,123.4 M 5,123.1 M -0.004%
compile Phobos codegen (instr) 1,472.5 M 1,472.2 M -0.022%
compile vibe.d (instr) 15,128.6 M 15,128.4 M -0.001%
dmd binary size (stripped) 6.86 MB 6.88 MB +0.23%
hello binary size (stripped) 0.72 MB 0.72 MB 0.00%
peak RSS (compile hello.d) 43.43 MB 43.40 MB -0.06%
peak RSS (compile Phobos) 617.8 MB 617.6 MB -0.03%
peak RSS (compile vibe.d) 1917 MB 1918 MB +0.07%
compile dmd itself (wall) 12.0 s 12.0 s +0.43%
compile hello.d (wall) 65.5 ms 66.6 ms +1.72%
compile Phobos (wall) 1,533 ms 1,515 ms -1.15%

7b6dc38 vs merge-base 078e406 · about these metrics

@rikkimax
rikkimax force-pushed the fastdfa-byref-local branch from d4ae26b to deba609 Compare September 1, 2026 05:56
@rikkimax
rikkimax force-pushed the fastdfa-byref-local branch from deba609 to 7b6dc38 Compare September 1, 2026 06:12
@thewilsonator
thewilsonator merged commit ac520c6 into dlang:master Sep 2, 2026
41 of 42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thewilsonator thewilsonator thewilsonator approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rikkimax @thewilsonator