Fix/19080 macro name highlight - #23764
Merged
thewilsonator merged 3 commits intoSep 2, 2026
Merged
Conversation
The DDoc auto-symbol-highlighting pass would highlight any word matching a declared symbol name, even when that word was the name of a DDoc macro invocation like $(test test). This corrupted the macro name text so the macro engine could no longer recognize and expand it. Fix: track when we're at the position of a macro name (right after $(), and skip auto-highlighting only for that specific identifier, not for macro arguments (which should still be highlighted normally, per the existing ddoc17697.d test).
DMD perf check
All measurements
7a2e468 vs merge-base 4264da7 · about these metrics |
thewilsonator
approved these changes
Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #19080