Unconditionally scan the callee before inline cost computation - #23767
Merged
Conversation
DMD perf check
All measurements
0b231e9 vs merge-base 4264da7 · about these metrics |
thewilsonator
approved these changes
Sep 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows the test case in #23766 to be fully inlined when compiled with
-inline, but does not fix the root cause that function literals in initializers nested within template mixins do not have a separate symbol table entry (so scans miss them).Generally this should allow a handful more of functions to be inlined. Let's check out the performance impact.
BTW, this is very hard to test due to how mixins work.