Fix Issue 21347 - array literal parser doesn't stop on missing comma - #23772
Merged
thewilsonator merged 1 commit intoSep 3, 2026
Merged
Conversation
… syntax error When a comma is missing after an element in an array literal or a subscript argument list, the parser used to keep consuming tokens past the syntax error all the way to the end of file, producing a long cascade of spurious errors instead of a small, focused set. Break out of the parsing loop as soon as a required comma is missing, after reporting the original error, instead of continuing to loop until the closing bracket or end of file is reached. Fixes Bugzilla Issue 21347
DMD perf check
Breakdown — compile hello.d
Breakdown — compile Phobos+60.4 M instructions: frontend +59.8 M (+1.64%), codegen +0.7 M (+0.04%)
All measurements
eecd1b2 vs merge-base 52c8c25 · about these metrics |
thewilsonator
approved these changes
Sep 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #21347