dmd.error: expose ErrorSink to C++ compiler interface - #23773
Merged
Conversation
ibuclaw
commented
Sep 3, 2026
| uint32_t errorLimit; | ||
| Diagnostic useWarnings; | ||
| Diagnostic useDeprecated; | ||
| d_bool showGaggedErrors; |
Member
Author
There was a problem hiding this comment.
@dkorpel the cpp layout checker can't handle overload sets, but it's not a big deal if they're missing here. :-(
ibuclaw
force-pushed
the
error_sink_cpp
branch
from
September 3, 2026 09:20
baba503 to
0b88e42
Compare
ibuclaw
force-pushed
the
error_sink_cpp
branch
from
September 3, 2026 10:17
0b88e42 to
b0841ce
Compare
ibuclaw
commented
Sep 3, 2026
| } | ||
| } | ||
| else if (!cast(ErrorSinkNull)eSink) | ||
| else |
thewilsonator
approved these changes
Sep 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So that gdc/ldc can override the
ErrorSinkCompilerclass to send errors to their backend diagnostics engine.e.g: