Fix unclear "cannot uniquely infer foreach argument types" diagnostic - #23780
Open
usefahmed07 wants to merge 2 commits into
Open
Fix unclear "cannot uniquely infer foreach argument types" diagnostic#23780usefahmed07 wants to merge 2 commits into
usefahmed07 wants to merge 2 commits into
Conversation
…es' diagnostic Add supplemental error messages explaining why no opApply overload matched a foreach statement's parameters (parameter count mismatch, qualifier/mutability mismatch, or explicit type mismatch), instead of the previous generic error with no further detail. The added diagnostics are only printed when no more specific error (e.g. ambiguous overload match) was already reported for the same failure, to avoid duplicating existing diagnostics.
…es' diagnostic Add supplemental error messages explaining why no opApply overload matched a foreach statement's parameters (parameter count mismatch, qualifier/mutability mismatch, or explicit type mismatch), instead of the previous generic error with no further detail. The added diagnostics are only printed when no more specific error (e.g. ambiguous overload match) was already reported for the same failure, to avoid duplicating existing diagnostics.
Contributor
Author
thewilsonator
left a comment
thewilsonator
left a comment
Contributor
There was a problem hiding this comment.
Otherwise looks fine
| if (!p.type) | ||
| continue; | ||
| Parameter param = tdg.parameterList[u]; | ||
| if (!p.type.equals(param.type)) |
Contributor
There was a problem hiding this comment.
if (p.type.equals(param.type))
continue;
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #19465