Skip to content

Fix Pantheon backup freshness check comparing epoch to formatted date #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sgenini wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix Pantheon backup freshness check comparing epoch to formatted date #97

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
59f3f1e
Fix Pantheon backup freshness check comparing epoch to formatted date
sgenini Aug 12, 2026
62fe9d6
Quote the date argument to avoid relying on word-splitting
sgenini Aug 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion pull/pull
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -535,7 +535,11 @@ provider_pull_pantheon_db ()
local last_backup
last_backup=$(_exec -T "terminus backup:list ${hostingsite}.${hostingenv} --element=db --format=list --field=date | head -n 1")
if_failed_error "Error retrieving list of backups from Pantheon for ${hostingsite} on the ${hostingenv} environment"
if [[ "last_backup" == "" ]] || [[ "${last_backup}" < "${yesterday}" ]] || [[ "$force" == "force" ]]; then
if [[ "${last_backup}" != "" ]]; then
# terminus returns a raw epoch timestamp; convert to the same "Y-m-d H:M:S" format as $yesterday so the comparison below is meaningful.
last_backup=$(_exec date --date="@${last_backup%%.*}" "+%Y-%m-%d %H:%M:%S")
fi
if [[ "${last_backup}" == "" ]] || [[ "${last_backup}" < "${yesterday}" ]] || [[ "$force" == "force" ]]; then
# If last backup does not exist or is older than 24 hours create new one.
echo -e "${acqua}Creating new backup on Pantheon for ${hostingsite} on the ${hostingenv} environment${NC}"
_exec terminus backup:create ${hostingsite}.${hostingenv} --element=db
Expand Down