upgrade spotbugs and exclude generated

Author: denis-yuen

.github/workflows/maven.yml

@@ -42,7 +42,7 @@ jobs:
 
      - name: Test Java build 
        working-directory: ./wdl-parsing/WDLParsingFunction
-       run: mvn clean install
+       run: mvn -B -ntp clean install
 
      - name: Test wdl parsing with SAM CLI build and invoke
        working-directory: ./wdl-parsing

wdl-parsing/WDLParsingFunction/ignore.xml

@@ -1,16 +1,13 @@
 <?xml version="1.0" encoding="UTF-8"?>
-<!-- Ignore generated files that we have little control over -->
-<FindBugsFilter>
-    <Match>
-        <Source name="WorkflowsApi.java"/>
-    </Match>
-    <Match>
-        <Source name="ServerVariable.java"/>
-    </Match>
-    <Match>
-        <Source name="ServerConfiguration.java"/>
-    </Match>
-    <Match>
-        <Source name="ApiClient.java"/>
-    </Match>
+  <FindBugsFilter
+              xmlns="https://github.com/spotbugs/filter/4.10.0"
+              xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+              xsi:schemaLocation="https://github.com/spotbugs/filter/4.10.0 https://raw.githubusercontent.com/spotbugs/spotbugs/4.10.0/spotbugs/etc/findbugsfilter.xsd">
+
+  <!-- All bugs in generated classes -->
+  <Match>
+  <Class name="~.*\.*dockstore.openapi.client.*" />
+  </Match>
 </FindBugsFilter>
+
+

wdl-parsing/WDLParsingFunction/pom.xml

@@ -221,7 +221,7 @@
             <plugin>
                 <groupId>com.github.spotbugs</groupId>
                 <artifactId>spotbugs-maven-plugin</artifactId>
-                <version>4.0.4</version>
+                <version>4.9.8.3</version>
                 <configuration>
                     <excludeFilterFile>${project.basedir}/ignore.xml</excludeFilterFile>
                 </configuration>