fix(link): isolate per-link target overrides

Author: Your Name

src/core/render/compiler.js

@@ -160,7 +160,7 @@ export class Compiler {
 
   _initRenderer() {
     const renderer = new marked.Renderer();
-    const { linkTarget, linkRel, router, contentBase } = this;
+    const { linkTarget, router, contentBase } = this;
     // Supports mermaid
     const origin = {};
 
@@ -179,7 +179,6 @@ export class Compiler {
       renderer,
       router,
       linkTarget,
-      linkRel,
       compiler: this,
     });
     origin.paragraph = paragraphCompiler({ renderer });

src/core/render/compiler/link.js

@@ -4,8 +4,7 @@ import { isAbsolutePath } from '../../router/util.js';
 export const linkCompiler = ({
   renderer,
   router,
-  linkTarget,
-  linkRel,
+  linkTarget: defaultLinkTarget,
   compiler,
 }) =>
   (renderer.link = function ({ href, title = '', tokens }) {
@@ -16,8 +15,8 @@ export const linkCompiler = ({
     const isNotCompilable = compiler._matchNotCompileLink(href);
     const isMailto = href.startsWith('mailto:');
 
-    linkTarget = config.target || linkTarget;
-    linkRel =
+    const linkTarget = config.target || defaultLinkTarget;
+    const linkRel =
       linkTarget === '_blank'
         ? compiler.config.externalLinkRel || 'noopener'
         : '';

test/integration/render.test.js

@@ -352,6 +352,21 @@ Text</p></div>"
       );
     });
 
+    test.each([
+      'https://example.org/first',
+      '/first',
+      'mailto:first@example.org',
+    ])('does not leak a target override from %s into later links', href => {
+      const container = document.createElement('div');
+      container.innerHTML = window.marked(
+        `[First](${href} ':target=_self')\n\n[Second](https://example.org/second)`,
+      );
+
+      const secondLink = container.querySelectorAll('a')[1];
+      expect(secondLink.target).toBe('_blank');
+      expect(secondLink.rel).toBe('noopener');
+    });
+
     test('target for relative path', async function () {
       const output = window.marked("[alt text](/url ':target=_blank')");