VideoCommon: refactor texture cache frame buffer copies - #14836
Open
iwubcode wants to merge 1 commit into
Open
Conversation
…on for a future enhancement
iwubcode
force-pushed
the
dolphin_texture_refactor_1
branch
from
August 31, 2026 06:59
d643c58 to
bcda14e
Compare
JoshuaVandaele
approved these changes
Aug 31, 2026
JoshuaVandaele
left a comment
JoshuaVandaele
left a comment
Contributor
There was a problem hiding this comment.
I played several Wii games and couldn't notice anything different, FifoCI seems happy as well.
Member
|
Having both FrameBufferCopyData and FrameBufferCopyParams feels wrong, especially with all methods taking both, and pulling data randomly from one or the other. Should be able to add a few more things to CopyParams and discard the CopyData after Params is built, right? Or just only have Params from the start |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Late last year I started working on a new feature that required Dolphin to think about how it renders in a different way. In order to prepare for that, I will be creating some PRs that restructure or refactor our existing code.
This PR is for the texture cache. Frame buffer copies (EFB or XFB) have a number of paths they take and this PR tries to split up the main function 'CopyRenderTargetToTexture' into smaller functions.
Functionality should not change with these PRs. I did some mild testing but fifo ci should hopefully confirm if any changes slipped through.