Repository navigation
Conversation
Use the MSVC stack allocator when preparing released amalgamations that contain a variable-length lock-path array. Preserve the source everywhere else and keep existing releases usable with the Windows publishing toolchain. Co-Authored-By: OpenAI Codex <noreply@openai.com>
Keep source-preservation coverage while relying on the existing Windows release-toolchain job to exercise the actual compiler failure. Co-Authored-By: OpenAI Codex <noreply@openai.com>
Artifact downloads strip executable modes. Restore both Unix CLI modes before packing, then smoke-test the actual npm archive and its native addon and CLI. The current 0.51.1 archive fails this check before the permission repair and passes afterward; the published npm version is immutable. Co-Authored-By: OpenAI Codex <noreply@openai.com>
timsehn
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Windows 0.51.0 and 0.51.1 prebuilds fail because MSVC rejects a variable-length lock-path array in the released source. Prepare that declaration with
_allocaunder MSVC while retaining the original stack allocation on other compilers.Artifact download also strips executable permissions from the bundled Unix CLIs before npm publication. Restore those modes and smoke-test the actual npm archive: verify both Unix CLI modes, load the native addon, execute SQL, and run the host CLI.
Validation: Windows release-toolchain CI passes against the 0.51.1 source archive, and all 129 binding tests pass locally. Source-preservation coverage reconstructs the original archive after removing compatibility fixes. The published 0.51.1 package fails the archive smoke test before permission repair and passes afterward. Already-fixed core source needs no lock-path compatibility rewrite.
Release status: the unpublished Node v0.51.1 tag was repaired at 4596413 with the compiler fix; npm publication and the parent release workflow are now green. The core tag and assets were preserved. The later CLI-permission fix in this PR requires the next npm version; the published 0.51.1 package still needs its bundled CLI made executable manually.
Co-Authored-By: OpenAI Codex noreply@openai.com