fix: handle malformed binding includes

Author: donglua

compiler-core/src/main/kotlin/com/github/donglua/layoutx2c/codegen/BindingFacadeGeneratorV2.kt

@@ -365,13 +365,24 @@ class BindingFacadeGeneratorV2(
                         "Missing required view with ID: ${field.idName}"
                     )
                 }
-                builder.addStatement(
-                    "val %L: %T = %T.bind(%L)",
-                    field.propertyName,
-                    field.viewClass,
-                    field.nestedBindingX2CClassName(),
-                    rootVarName
-                )
+                if (field.useNestedX2CBinding) {
+                    builder.addStatement(
+                        "val %L: %T = %T.bind(%L)",
+                        field.propertyName,
+                        field.viewClass,
+                        field.nestedBindingX2CClassName(),
+                        rootVarName
+                    )
+                } else {
+                    builder.addStatement(
+                        "val %L: %T = %T.bind(%L)\n⇥?: error(%S)⇤",
+                        field.propertyName,
+                        field.viewClass,
+                        ClassName("androidx.databinding", "DataBindingUtil"),
+                        rootVarName,
+                        "Missing required binding with ID: ${field.idName}"
+                    )
+                }
             } else if (field.isRoot) {
                 builder.addStatement(
                     "val %L = rootView as? %T\n⇥?: error(%S)⇤",

compiler-core/src/main/kotlin/com/github/donglua/layoutx2c/codegen/BindingFieldCollector.kt

@@ -10,6 +10,7 @@ data class BindingField(
     val viewClass: ClassName,
     val isRoot: Boolean = false,
     val isNestedBinding: Boolean = false,
+    val useNestedX2CBinding: Boolean = true,
     val nestedBindingLayoutName: String? = null
 )
 
@@ -48,6 +49,7 @@ class BindingFieldCollector(
                 viewClass = bindingViewClass(node, isNestedBinding),
                 isRoot = isRoot,
                 isNestedBinding = isNestedBinding,
+                useNestedX2CBinding = includeNode?.isMalformedDataBindingLayout != true,
                 nestedBindingLayoutName = includeNode?.layoutRef?.takeIf { isNestedBinding }
             )
         }

compiler-core/src/main/kotlin/com/github/donglua/layoutx2c/parser/LayoutNodeTypes.kt

@@ -10,6 +10,7 @@ sealed class LayoutNodeType {
         val layoutRef: String,
         val resolutionError: String? = null,
         val isDataBindingLayout: Boolean = false,
+        val isMalformedDataBindingLayout: Boolean = false,
         val includeAttributes: Map<String, String> = emptyMap()
     ) : LayoutNodeType()
     object Merge : LayoutNodeType()

compiler-core/src/main/kotlin/com/github/donglua/layoutx2c/parser/XmlLayoutParser.kt

@@ -100,7 +100,8 @@ class XmlLayoutParser(
                 is IncludeResult.Success -> {
                     val includedRoot = resolved.tree.root
                     val resolvedNodeType = nodeType.copy(
-                        isDataBindingLayout = resolved.tree.rootMetadata.isDataBindingLayout
+                        isDataBindingLayout = resolved.tree.rootMetadata.isDataBindingLayout,
+                        isMalformedDataBindingLayout = resolved.tree.rootMetadata.isMalformedDataBindingLayout
                     )
 
                     // If the included root is a <merge> tag, native Android ignores

compiler-core/src/test/kotlin/com/github/donglua/layoutx2c/codegen/BindingFacadeGeneratorV2Test.kt

@@ -109,6 +109,51 @@ class BindingFacadeGeneratorV2Test {
         assertThat(generated).doesNotContain("public val viewText: TextView")
     }
 
+    @Test
+    fun `malformed data binding include uses native binding instead of missing x2c facade`() {
+        tempFolder.newFile("broken_child.xml").writeText(
+            """
+                <layout xmlns:android="http://schemas.android.com/apk/res/android">
+                    <data>
+                        <variable
+                            name="title"
+                            type="java.lang.String" />
+                    </data>
+                </layout>
+            """.trimIndent()
+        )
+        val includeParser = XmlLayoutParser(includeResolver = IncludeResolver(tempFolder.root))
+        val tree = includeParser.parse(
+            """
+                <layout xmlns:android="http://schemas.android.com/apk/res/android">
+                    <FrameLayout
+                        android:layout_width="match_parent"
+                        android:layout_height="match_parent">
+                        <include
+                            android:id="@+id/broken"
+                            layout="@layout/broken_child"
+                            android:layout_width="match_parent"
+                            android:layout_height="wrap_content" />
+                    </FrameLayout>
+                </layout>
+            """.trimIndent(),
+            "host_with_broken_include"
+        )
+        val analyzed = analyzer.analyze(tree.root)
+
+        val generated = generator.generate(
+            analyzedRoot = analyzed,
+            layoutName = "host_with_broken_include",
+            layoutResId = "R.layout.host_with_broken_include",
+            useFastPath = true,
+            dataBindingVariables = tree.rootMetadata.dataBindingVariables
+        ).toString()
+
+        assertThat(generated).contains("val broken: BrokenChildBinding = DataBindingUtil.bind(brokenRoot)")
+        assertThat(generated).doesNotContain("BrokenChildX2CBinding.bind")
+        assertThat(generated).contains("setContainedBinding(broken)")
+    }
+
     @Test
     fun `generated binding binds root id field from root view directly`() {
         val xml = """