[graphql-modules-preset] fix: skip sources without a location or document under strict mode (#4683) (#10993)

Author: eddeee888

.changeset/brave-modules-skip.md

@@ -0,0 +1,5 @@
+---
+'@graphql-codegen/graphql-modules-preset': patch
+---
+
+Skip sources without a `location` when grouping sources by module, instead of throwing from `path.normalize`, and skip sources without a `document` AST when building each module's document. Generated output from the CLI is unchanged.

.changeset/wide-config-values.md

@@ -0,0 +1,5 @@
+---
+'@graphql-codegen/visitor-plugin-common': patch
+---
+
+Type `getConfigValue`'s `value` parameter as `T | null | undefined`, so the result is non-nullable when a non-nullable default is given.

packages/plugins/other/visitor-plugin-common/src/utils.ts

@@ -37,7 +37,7 @@ import type {
   ScalarsMap,
 } from './types.js';
 
-export const getConfigValue = <T = any>(value: T, defaultValue: T): T => {
+export const getConfigValue = <T = any>(value: T | null | undefined, defaultValue: T): T => {
   if (value === null || value === undefined) {
     return defaultValue;
   }

packages/presets/graphql-modules/src/builder.ts

@@ -439,7 +439,7 @@ export function buildModule(
         defined.objects.push(name);
         collectFields(node, picks.objects);
 
-        if (node.interfaces?.length > 0) {
+        if ((node.interfaces?.length ?? 0) > 0) {
           withIsTypeOf.objects.push(name);
         }
 
@@ -495,7 +495,7 @@ export function buildModule(
 
         pushUnique(extended.objects, name);
 
-        if (node.interfaces?.length > 0) {
+        if ((node.interfaces?.length ?? 0) > 0) {
           pushUnique(withIsTypeOf.objects, name);
         }
 

packages/presets/graphql-modules/src/index.ts

@@ -94,7 +94,9 @@ export const preset: Types.OutputPreset<ModulesConfig> = {
         normalize(join(relativePath, baseTypesFilename));
       const sources = sourcesByModuleMap[moduleName];
 
-      const moduleDocument = concatAST(sources.map(source => source.document));
+      const moduleDocument = concatAST(
+        sources.flatMap(source => (source.document ? [source.document] : [])),
+      );
 
       const shouldDeclare = filename.endsWith('.d.ts');
 
@@ -125,7 +127,7 @@ export const preset: Types.OutputPreset<ModulesConfig> = {
                   schema.getQueryType()?.name,
                   schema.getMutationType()?.name,
                   schema.getSubscriptionType()?.name,
-                ].filter(Boolean),
+                ].filter((name): name is string => typeof name === 'string'),
                 useTypeImports,
               }),
           },

packages/presets/graphql-modules/src/utils.ts

@@ -182,6 +182,10 @@ export function groupSourcesByModule(
   const grouped: Record<string, Source[]> = {};
 
   for (const source of sources) {
+    if (!source.location) {
+      continue;
+    }
+
     const relativePath = getRelativePath(source.location, basePath);
 
     if (relativePath) {