Repository navigation
CODEGEN-859 [graphql-modules-preset] Fix __isTypeOf getting picked from from all objects - #10447
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: d3256d9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
eddeee888
commented
Sep 23, 2025
| defined.unions.push(name); | ||
|
|
||
| for (const namedType of node.types || []) { | ||
| pushUnique(withIsTypeOf.objects, namedType.name.value); |
Collaborator
Author
There was a problem hiding this comment.
I'm using pushUnique for union type here (unlike .push on other type definition) because a union may contain a union member that already exists on another union declaration.
Contributor
Contributor
💻 Website PreviewThe latest changes are available as preview in: https://pr-10447.graphql-code-generator.pages.dev |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes
__isTypeOfgetting picked from all objects.With https://github.com/dotansimha/graphql-code-generator/releases/tag/release-1757264511789 release,
__isTypeOfis only generated for implementing types and union members.This PR applies the same logic to
graphql-modules-presetto make sure it's correctly picked.Related #10438
Type of change
How Has This Been Tested?