Repository navigation
[plugin-helpers] fix: guard isUsingTypes against union and interface types without fields (dotansimha/graphql-code-generator-community#934) - #11057
Open
agustin18 wants to merge 1 commit into
Conversation
…types without fields
🦋 Changeset detectedLatest commit: aa670b0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In
isUsingTypes, when an operation contains subselections on a field whose parent type is aGraphQLUnionType(or any non-object/non-interface type),lastType.getFields()throws:This unhandled error is caught by presets such as
near-operation-fileand masked as a genericUnable to validate GraphQL document!, preventing real GraphQL validation errors from reaching the user.Additionally, when resolving fields on
GraphQLInterfaceTypeinstances:Field.enter,isObjectType(lastType)returnedfalse, skipping nullability checks and potentially undercountingfoundFields.This PR:
typesStackasArray<GraphQLNamedType | undefined>instead ofGraphQLObjectType[], removing theas anycast ontypesStack.push(...).Kind.FIELDbranch ofSelectionSet.enter, guardslastTypewithisObjectType(lastType) || isInterfaceType(lastType)before accessing.getFields(), safely returningnullwhen the parent cannot define fields.Kind.INLINE_FRAGMENT, safely resolvestypesStack[typesStack.length - 1]?.name || null.Field.enter, updates the check toisObjectType(lastType) || isInterfaceType(lastType)so interface fields are properly recognized.Related dotansimha/graphql-code-generator-community#934
Type of change
How Has This Been Tested?
packages/utils/plugins-helpers/tests/is-using-types.spec.ts:community #934 - should not crash when selecting fields on union typeshould correctly detect types and nullable fields on interface typesshould handle untyped inline fragments on unions without errorpnpm vitest run packages/utils/plugins-helpers/tests/is-using-types.spec.ts) - 11/11 tests passing.pnpm types:checkandpnpm prettier:check.Test Environment:
@graphql-codegen/plugin-helpers: 7.4.2Checklist: